Skip to content

CHORE: remove cancelled() checks from vm_test workflow#582

Merged
cmainas merged 2 commits into
urunc-dev:main-pr582from
kaizakin:fix/tests
May 5, 2026
Merged

CHORE: remove cancelled() checks from vm_test workflow#582
cmainas merged 2 commits into
urunc-dev:main-pr582from
kaizakin:fix/tests

Conversation

@kaizakin
Copy link
Copy Markdown
Contributor

@kaizakin kaizakin commented Apr 28, 2026

Description

if: ${{ !cancelled() }} condition in vm_test.yml enabled the tests to run even if any of the previous steps failed.

Related issues

How was this tested?

tested this by intentionally changing the firecraker release url and triggered a workflow in my fork.

once the firecracker step failed further jobs were skipped.

image

LLM usage

N/A

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 28, 2026

Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit 23a2db1
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/69fa16463373ca0008f3671d

@kaizakin kaizakin marked this pull request as ready for review April 28, 2026 20:00
@cmainas
Copy link
Copy Markdown
Contributor

cmainas commented Apr 29, 2026

Hello @kaizakin ,

thank you for this PR, do you have a link to the actions in your fork?

@kaizakin
Copy link
Copy Markdown
Contributor Author

Hey @cmainas thanks for checking out.

here's the link to the action run https://github.com/kaizakin/urunc/actions/runs/25074394005/job/73463209304

@cmainas
Copy link
Copy Markdown
Contributor

cmainas commented May 4, 2026

Thank you @kaizakin for the link.

Please add yourself in https://github.com/urunc-dev/urunc/blob/main/.github/contributors.yaml and rebase over main, so we can merge.

@kaizakin
Copy link
Copy Markdown
Contributor Author

kaizakin commented May 4, 2026

done 👍 @cmainas

@kaizakin kaizakin force-pushed the fix/tests branch 2 times, most recently from b86fdfa to 29dc3bc Compare May 5, 2026 08:07
@cmainas
Copy link
Copy Markdown
Contributor

cmainas commented May 5, 2026

Hello @kaizakin , could you please rebase over main once more?

Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
@kaizakin
Copy link
Copy Markdown
Contributor Author

kaizakin commented May 5, 2026

rebased @cmainas 👍

Copy link
Copy Markdown
Contributor

@cmainas cmainas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kaizakin ,

please add your full name in the contributors.yaml.

Comment thread .github/contributors.yaml Outdated
name: Beingana Jim Junior
email: jimjunior854@gmail.com
kaizakin:
name: Karthik B
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your full name.

@kaizakin
Copy link
Copy Markdown
Contributor Author

kaizakin commented May 5, 2026

@cmainas actually my legal full name is Karthik B 😅, Even though my name is Karthik Balasubramanian as per the documents my name is karthik B.

I could change it to Karthik Balasubramanian if you want.

@cmainas
Copy link
Copy Markdown
Contributor

cmainas commented May 5, 2026

Yes, change it to Balasubramanian.

Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
@kaizakin
Copy link
Copy Markdown
Contributor Author

kaizakin commented May 5, 2026

Thanks for the comment @cmainas , i've changed my name now

@urunc-bot urunc-bot Bot changed the base branch from main to main-pr582 May 5, 2026 17:08
Copy link
Copy Markdown
Contributor

@cmainas cmainas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kaizakin .

@cmainas cmainas merged commit 7c1c4b2 into urunc-dev:main-pr582 May 5, 2026
34 checks passed
github-actions Bot pushed a commit that referenced this pull request May 5, 2026
PR: #582
Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
github-actions Bot pushed a commit that referenced this pull request May 5, 2026
PR: #582
Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot pushed a commit that referenced this pull request May 5, 2026
PR: #582
Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot pushed a commit that referenced this pull request May 5, 2026
PR: #582
Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not run the e2e tests if a setup action in the workflow fails

2 participants