CHORE: remove cancelled() checks from vm_test workflow#582
Conversation
✅ Deploy Preview for urunc canceled.
|
|
Hello @kaizakin , thank you for this PR, do you have a link to the actions in your fork? |
|
Hey @cmainas thanks for checking out. here's the link to the action run https://github.com/kaizakin/urunc/actions/runs/25074394005/job/73463209304 |
|
Thank you @kaizakin for the link. Please add yourself in https://github.com/urunc-dev/urunc/blob/main/.github/contributors.yaml and rebase over main, so we can merge. |
|
done 👍 @cmainas |
b86fdfa to
29dc3bc
Compare
|
Hello @kaizakin , could you please rebase over main once more? |
Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
|
rebased @cmainas 👍 |
| name: Beingana Jim Junior | ||
| email: jimjunior854@gmail.com | ||
| kaizakin: | ||
| name: Karthik B |
|
@cmainas actually my legal full name is Karthik B 😅, Even though my name is Karthik Balasubramanian as per the documents my name is karthik B. I could change it to Karthik Balasubramanian if you want. |
|
Yes, change it to Balasubramanian. |
Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
|
Thanks for the comment @cmainas , i've changed my name now |
PR: #582 Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
PR: #582 Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
PR: #582 Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
PR: #582 Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Description
if: ${{ !cancelled() }}condition invm_test.ymlenabled the tests to run even if any of the previous steps failed.Related issues
How was this tested?
tested this by intentionally changing the firecraker release url and triggered a workflow in my fork.
once the firecracker step failed further jobs were skipped.
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).