Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
u | dfa7681 | Commit Preview URL Branch Preview URL |
Mar 21 2026, 06:01 PM |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemoved the registry's authentication and database stack, deleted procedural docs, updated CI and tooling configs, and refactored the userscript build by extracting a virtual-module plugin and adjusting tests and package metadata. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~65 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
packages/usts/src/core/build/plugin.ts (1)
14-20: Parameteridshadows outer constant.The
load(id)parameter on line 14 shadows theidconstant declared on line 4. While functionally correct (line 15 compares againstresolvedId), this can cause confusion during maintenance.♻️ Rename parameter to clarify intent
- load(id) { - if (id === resolvedId) { + load(loadedId) { + if (loadedId === resolvedId) { return `const IS_DEV = ${options?.dev ?? false}; export { IS_DEV };`; } return null; },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/usts/src/core/build/plugin.ts` around lines 14 - 20, The load(id) parameter shadows the outer constant id; rename the parameter (e.g., to incomingId or requestedId) in the load function and update its usage inside that function (the equality check against resolvedId and the return path) so the outer constant id is not shadowed; ensure the function signature and any references in the same closure (load) are consistently renamed to avoid confusion when locating the symbol load and the outer id constant.package.json (1)
34-43: Pinunstorageto a specific version to ensure reproducible builds.Using the
alphadist-tag without a specific version causes non-reproducible builds—different installs at different times may resolve to different versions if new alpha releases are published. Currently, thealphatag points to2.0.0-alpha.7. Pin it to prevent this:- "unstorage": "alpha" + "unstorage": "^2.0.0-alpha.7"Note: The
@babel/*packages are at8.0.0-rc.3(still pre-release). Update them once v8 reaches stable release.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 34 - 43, The overrides entry pins "unstorage" to the unstable dist-tag "alpha", causing non-reproducible installs; update package.json's overrides for "unstorage" (the overrides object) to a specific published version (e.g., "2.0.0-alpha.7") instead of "alpha" so installs resolve deterministically.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/usts/package.json`:
- Around line 17-19: The package.json's "files" array currently only includes
"dist", so the declared export "./types": "./virtual.d.ts" will not be
published; update the package.json by adding "virtual.d.ts" (or the path to it)
to the "files" array so the file is included in the published package and the
"./types" export resolves correctly.
In `@packages/usts/src/types/virtual.d.ts`:
- Around line 1-4: The declaration for module "usts:runtime" currently misuses a
type export for a value; replace the incorrect "const IS_DEV: boolean; export
type { IS_DEV }" pattern with a value export that matches the runtime plugin
(plugin.ts exports IS_DEV). Concretely, update the module declaration to export
the value symbol IS_DEV as a const value (e.g., export const IS_DEV: boolean) so
the .d.ts matches the runtime export and avoids the `export type` misuse.
---
Nitpick comments:
In `@package.json`:
- Around line 34-43: The overrides entry pins "unstorage" to the unstable
dist-tag "alpha", causing non-reproducible installs; update package.json's
overrides for "unstorage" (the overrides object) to a specific published version
(e.g., "2.0.0-alpha.7") instead of "alpha" so installs resolve
deterministically.
In `@packages/usts/src/core/build/plugin.ts`:
- Around line 14-20: The load(id) parameter shadows the outer constant id;
rename the parameter (e.g., to incomingId or requestedId) in the load function
and update its usage inside that function (the equality check against resolvedId
and the return path) so the outer constant id is not shadowed; ensure the
function signature and any references in the same closure (load) are
consistently renamed to avoid confusion when locating the symbol load and the
outer id constant.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e2b1d406-6acc-4f56-aded-821c7627b237
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (26)
.github/workflows/ci.yml.gitignoreAGENTS.mdapps/registry/package.jsonapps/registry/src/components/SignInButton.tsxapps/registry/src/db/auth-schema.tsapps/registry/src/db/index.tsapps/registry/src/db/schema.tsapps/registry/src/env/index.tsapps/registry/src/lib/auth/client.tsapps/registry/src/lib/auth/index.tsapps/registry/src/pages/404.astroapps/registry/src/pages/500.astroapps/registry/src/pages/api/[...slugs].tsapps/registry/src/pages/dashboard/index.astroapps/registry/src/pages/login/index.astroapps/registry/src/router/auth/index.tsapps/registry/src/router/index.tsapps/registry/src/router/userscripts/index.tsbiome.jsonpackage.jsonpackages/usts/package.jsonpackages/usts/src/config/schema.tspackages/usts/src/core/build/options.tspackages/usts/src/core/build/plugin.tspackages/usts/src/types/virtual.d.ts
💤 Files with no reviewable changes (15)
- apps/registry/src/lib/auth/client.ts
- .gitignore
- apps/registry/src/components/SignInButton.tsx
- apps/registry/src/pages/api/[...slugs].ts
- apps/registry/src/db/schema.ts
- apps/registry/src/router/index.ts
- apps/registry/src/pages/login/index.astro
- apps/registry/src/db/index.ts
- apps/registry/src/router/auth/index.ts
- AGENTS.md
- apps/registry/src/env/index.ts
- apps/registry/src/lib/auth/index.ts
- apps/registry/src/db/auth-schema.ts
- apps/registry/src/router/userscripts/index.ts
- apps/registry/src/pages/dashboard/index.astro
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/usts/tests/basic.test.ts (1)
50-66: Consider adding the complementary DEV-branch assertion.This test is valuable, but it only checks the production branch. Add a paired case that asserts the
[DEV]output path so both sides of theIS_DEVconditional transformation are protected.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/usts/tests/basic.test.ts` around lines 50 - 66, Add a complementary test that verifies the IS_DEV branch by calling resolveFixture("fixtures/virtual/index.ts") and invoking buildUserscript in a dev mode (set the environment or options so IS_DEV is true for the run of buildUserscript), then assert the output contains the "[DEV] Hello world!" bundle (use toMatchInlineSnapshot or a direct expect string) similar to the existing "correctly bundles a basic userscript when using IS_DEV variable" test; ensure you restore any modified env after the test so other tests are unaffected and keep the test name descriptive (e.g., "correctly bundles a basic userscript when IS_DEV is true").
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/usts/tests/basic.test.ts`:
- Around line 50-66: Add a complementary test that verifies the IS_DEV branch by
calling resolveFixture("fixtures/virtual/index.ts") and invoking buildUserscript
in a dev mode (set the environment or options so IS_DEV is true for the run of
buildUserscript), then assert the output contains the "[DEV] Hello world!"
bundle (use toMatchInlineSnapshot or a direct expect string) similar to the
existing "correctly bundles a basic userscript when using IS_DEV variable" test;
ensure you restore any modified env after the test so other tests are unaffected
and keep the test name descriptive (e.g., "correctly bundles a basic userscript
when IS_DEV is true").
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 115f01b0-b0d5-4dc5-9200-6b0535502066
📒 Files selected for processing (2)
packages/usts/tests/basic.test.tspackages/usts/tests/fixtures/virtual/index.ts
✅ Files skipped from review due to trivial changes (1)
- packages/usts/tests/fixtures/virtual/index.ts
Summary by CodeRabbit
Removed Features
Infrastructure
Tests