Skip to content

Conversation

@Aariq
Copy link
Collaborator

@Aariq Aariq commented Mar 3, 2025

Addresses #97

  • Allows a more R-like input for DOY—c(1,5)
  • Deprecates character input for DOY—"1,5" with a warning
  • Allows Date objects or "YYYY-MM-DD" as inputs

@Aariq Aariq marked this pull request as ready for review March 11, 2025 22:20
@Aariq Aariq linked an issue Mar 11, 2025 that may be closed by this pull request
@Aariq Aariq changed the title [WIP] Input validation for date arg of npn_download_geospatial() Input validation for date arg of npn_download_geospatial() Mar 11, 2025
@Aariq Aariq requested a review from ezylstra June 23, 2025 23:20
@ezylstra
Copy link
Collaborator

Looks good to me. However, I can't test calls to npn_download_geospatial() right now without first changing the base-reqs file (geoserver url http -> https) as Jeff suggested. I wasn't sure whether it makes sense to wait on that or not since Jeff is still working on geoserver stuff.

@Aariq
Copy link
Collaborator Author

Aariq commented Jul 25, 2025

Still to do:

This apply coerces numeric inputs back to character, triggering the deprecation warning:

get_additional_rasters <- function(data) {

@Aariq Aariq marked this pull request as draft July 25, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve validation for date argument to npn_download_geospatial()

3 participants