Skip to content

Conversation

@cmichi
Copy link
Collaborator

@cmichi cmichi commented Mar 24, 2025

No description provided.

@cmichi cmichi requested a review from ascjones as a code owner March 24, 2025 21:38
@cmichi cmichi removed the request for review from ascjones March 24, 2025 21:38
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract-contract and comparing them to ink! master:

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
call-builder-return-value 35.189 35.188 -0.001 -0.0028418 📉
call-runtime 19.273 19.274 0.001 0.00518861 📈
combined-extension 17.74 17.738 -0.002 -0.011274 📉
complex-storage-structures 32.609 32.606 -0.003 -0.00919991 📉
conditional-compilation 14.379 14.379 0 0
contract-invocation 40.73 40.731 0.001 0.00245519 📈
contract-invocation/contract1 15.632 15.631 -0.001 -0.00639713 📉
contract-invocation/contract2 15.568 15.568 0 0
contract-invocation/virtual_contract 33.116 33.114 -0.002 -0.00603938 📉
contract-invocation/virtual_contract_ver1 15.304 15.304 0 0
contract-invocation/virtual_contract_ver2 15.318 15.318 0 0
contract-storage 32.029 32.027 -0.002 -0.00624434 📉
contract-terminate 15.268 15.265 -0.003 -0.0196489 📉
contract-transfer 18.909 18.907 -0.002 -0.010577 📉
contract-xcm 56.69 56.689 -0.001 -0.00176398 📉
cross-contract-calls 38.828 38.824 -0.004 -0.0103018 📉
cross-contract-calls/other-contract 14.435 14.434 -0.001 -0.00692761 📉
custom-allocator 16.58 16.581 0.001 0.00603136 📈
custom-environment 16.516 16.515 -0.001 -0.00605473 📉
dns 38.319 38.318 -0.001 -0.00260967 📉
e2e-call-runtime 16.349 16.349 0 0
e2e-runtime-only-backend 17.014 17.014 0 0
erc1155 54.511 54.51 -0.001 -0.00183449 📉
erc20 40.069 40.067 -0.002 -0.00499139 📉
erc721 42.183 42.182 -0.001 -0.00237062 📉
events 21.381 21.382 0.001 0.00467705 📈
flipper 14.503 14.505 0.002 0.0137903 📈
incrementer 14.61 14.608 -0.002 -0.0136893 📉
lang-err/call-builder 37.35 37.348 -0.002 -0.00535475 📉
lang-err/call-builder-delegate 31.814 31.813 -0.001 -0.00314327 📉
lang-err/constructors-return-value 15.679 15.679 0 0
lang-err/contract-ref 39.623 39.623 0 0
lang-err/integration-flipper 14.959 14.959 0 0
lazyvec 33.695 33.692 -0.003 -0.0089034 📉
mapping 39.293 39.292 -0.001 -0.00254498 📉
mother 26.636 26.634 -0.002 -0.00750863 📉
multi-contract-caller 46.772 46.772 0 0
multi-contract-caller/accumulator 14.459 14.46 0.001 0.00691611 📈
multi-contract-caller/adder 31.706 31.705 -0.001 -0.00315398 📉
multi-contract-caller/subber 31.755 31.753 -0.002 -0.00629822 📉
multisig 62.478 62.476 -0.002 -0.00320113 📉
own-code-hash 30.636 30.635 -0.001 -0.00326413 📉
payment-channel 44.936 44.939 0.003 0.00667616 📈
psp22-extension 23.734 23.735 0.001 0.00421336 📈
rand-extension 18.82 18.822 0.002 0.010627 📈
runtime-call-contract 14.429 14.429 0 0
sol-cross-contract 21.238 21.237 -0.001 -0.00470854 📉
sol-cross-contract/other-contract-sol 16.018 16.016 -0.002 -0.012486 📉
sol_encoding 15.918 15.918 0 0
solidity-calls-flipper 37.39 37.391 0.001 0.00267451 📈
sr25519-verification 13.979 13.979 0 0
static-buffer 16.308 16.308 0 0
storage-types 28.487 28.485 -0.002 -0.00702075 📉
trait-dyn-cross-contract-calls 32.092 32.09 -0.002 -0.00623208 📉
trait-dyn-cross-contract-calls/contracts/incrementer 14.534 14.534 0 0
trait-erc20 40.31 40.31 0 0
trait-incrementer 14.584 14.583 -0.001 -0.00685683 📉
upgradeable-contracts/delegator 34.913 34.912 -0.001 -0.00286426 📉
upgradeable-contracts/delegator/delegatee 30.498 30.498 0 0
upgradeable-contracts/delegator/delegatee2 30.498 30.497 -0.001 -0.0032789 📉
upgradeable-contracts/set-code-hash 15.068 15.068 0 0
upgradeable-contracts/set-code-hash-migration 15.084 15.084 0 0
upgradeable-contracts/set-code-hash-migration/migration 15.331 15.331 0 0
upgradeable-contracts/set-code-hash-migration/updated-incrementer 15.324 15.324 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 15.051 15.051 0 0
wildcard-selector 16.579 16.58 0.001 0.00603173 📈

Link to the run | Last update: Fri Mar 28 12:10:04 CET 2025

@cmichi cmichi merged commit 38594e3 into master Mar 28, 2025
@cmichi cmichi deleted the cmichi-fix-contract-sizes7 branch March 28, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants