Skip to content

Conversation

@davidsemakula
Copy link
Collaborator

Summary

Closes #_

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on a specific version of cargo-contract or pallet-revive?

Description

  • Support global contract attribute macro paths (i.e. #[::ink::contract]) in scripts/is_contract.sh checker
  • Fix trait-flipper integration test

Checklist before requesting a review

  • I have added an entry to CHANGELOG.md
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with 0 and comparing them to ink! master:

Show Results
Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
call-builder-return-value 20.807 20.807 0 0
call-runtime 2.195 2.195 0 0
combined-extension 2.51 2.51 0 0
complex-storage-structures 4.296 4.296 0 0
conditional-compilation 1.448 1.448 0 0
contract-invocation 7.935 7.935 0 0
contract-invocation/contract1 1.844 1.844 0 0
contract-invocation/contract2 1.804 1.804 0 0
contract-invocation/virtual_contract 4.222 4.222 0 0
contract-invocation/virtual_contract_ver1 1.852 1.852 0 0
contract-invocation/virtual_contract_ver2 1.864 1.864 0 0
contract-storage 18.472 18.472 0 0
contract-terminate 1.414 1.414 0 0
contract-transfer 3.036 3.036 0 0
contract-xcm 28.206 28.206 0 0
cross-contract-calls 8.774 8.774 0 0
cross-contract-calls/other-contract 1.524 1.524 0 0
custom-allocator 3.012 3.012 0 0
custom-environment 2.23 2.23 0 0
debugging-strategies 4.086 4.086 0 0
dns 8.058 8.058 0 0
e2e-call-runtime 1.674 1.674 0 0
e2e-runtime-only-backend 2.25 2.25 0 0
erc1155 19.194 19.194 0 0
erc20 9.446 9.446 0 0
erc721 11.034 11.034 0 0
events 5.982 5.982 0 0
flipper 1.597 1.597 0 0
incrementer 1.284 1.284 0 0
lang-err/call-builder 8.458 8.458 0 0
lang-err/call-builder-delegate 3.136 3.136 0 0
lang-err/constructors-return-value 2.225 2.225 0 0
lang-err/contract-ref 7.626 7.626 0 0
lang-err/integration-flipper 1.795 1.795 0 0
lazyvec 4.908 4.908 0 0
mapping 9.508 9.508 0 0
mother 13.622 13.622 0 0
multi-contract-caller 12.782 12.782 0 0
multi-contract-caller/accumulator 1.141 1.141 0 0
multi-contract-caller/adder 3.129 3.129 0 0
multi-contract-caller/subber 3.137 3.137 0 0
multisig 24.379 24.379 0 0
own-code-hash 2.204 2.204 0 0
payment-channel 11.014 11.014 0 0
psp22-extension 7.379 7.379 0 0
rand-extension 3.451 3.451 0 0
runtime-call-contract 1.527 1.527 0 0
solidity-abi/events 5.248 5.248 0 0
solidity-abi/sol-cross-contract 4.907 4.907 0 0
solidity-abi/sol-cross-contract/other-contract-sol 1.634 1.634 0 0
solidity-abi/sol-encoding 1.56 1.56 0 0
solidity-abi/solidity-calls-flipper 6.253 6.253 0 0
sr25519-verification 0.957 0.957 0 0
static-buffer 2.503 2.503 0 0
storage-types 15.918 15.918 0 0
trait-dyn-cross-contract-calls 3.579 3.579 0 0
trait-dyn-cross-contract-calls/contracts/incrementer 1.589 1.589 0 0
trait-erc20 9.746 9.746 0 0
trait-incrementer 1.659 1.659 0 0
upgradeable-contracts/delegator 5.877 5.877 0 0
upgradeable-contracts/delegator/delegatee 2.621 2.621 0 0
upgradeable-contracts/delegator/delegatee2 2.62 2.62 0 0
upgradeable-contracts/set-code-hash 1.503 1.503 0 0
upgradeable-contracts/set-code-hash-migration 1.503 1.503 0 0
upgradeable-contracts/set-code-hash-migration/migration 1.67 1.67 0 0
upgradeable-contracts/set-code-hash-migration/updated-incrementer 1.701 1.701 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 1.463 1.463 0 0
wildcard-selector 2.79 2.79 0 0

Link to the run | Last update: Fri May 30 09:25:35 CEST 2025

@davidsemakula davidsemakula marked this pull request as ready for review May 30, 2025 07:29
@davidsemakula davidsemakula merged commit 641f057 into master May 30, 2025
33 of 34 checks passed
@davidsemakula davidsemakula deleted the semakula/is-contract-checker branch May 30, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants