clarify(blacksmith-cache): make hydration-in-progress fallback log explicit#27
Merged
Merged
Conversation
…plicit When GetStickyDisk returns Code.Aborted (another job is hydrating the mirror), no sticky disk is mounted for this run and checkout clones directly from GitHub onto the runner's local disk. The previous 'Falling back to standard checkout' wording was ambiguous about that. Update the warning to state explicitly that no sticky disk is mounted and the checkout is happening on the runner disk with no mirror cache. Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
GetStickyDiskreturnsCode.Abortedbecause another job is hydrating the git mirror, the previous log wording ("Falling back to standard checkout") left it unclear whether the checkout was still happening on a sticky disk (potentially an empty one) or on the runner's regular disk. It is the latter: the gRPC call is aborted before any disk is allocated, formatted, or mounted, so the subsequent git init/fetch clones directly from GitHub onto/home/runner/_work/...on the VM's rootfs, with no mirror cache involved.This PR updates the second
core.warningin theCode.Abortedcatch block insrc/blacksmith-cache.tsto state that explicitly: no sticky disk is mounted for this run, the checkout clones directly from GitHub onto the runner disk, and the mirror cache will be available on subsequent runs once hydration completes.dist/index.jsis updated to match so thecheck-distworkflow passes.No behavioral change, only log wording.
Codesmith can help with this PR — just tag
@codesmithor enable autofix.Codesmith can help with this PR — just tag
@codesmithor enable autofix.