Skip to content

fix: fallback to docker-container driver when default builder uses docker driver#86

Merged
adityamaru merged 4 commits intomainfrom
fix/fallback-docker-container-driver
Mar 27, 2026
Merged

fix: fallback to docker-container driver when default builder uses docker driver#86
adityamaru merged 4 commits intomainfrom
fix/fallback-docker-container-driver

Conversation

@adityamaru
Copy link
Copy Markdown
Contributor

@adityamaru adityamaru commented Mar 27, 2026

When the Blacksmith remote builder setup fails and the action falls back to a local builder, it inspects the current builder and reuses it if one exists. However, if the default builder uses the docker driver (which doesn't support attestation or many buildx features), the fallback silently uses an incompatible builder instead of creating one with the docker-container driver.

This adds a driver check to the fallback path so that a docker-driver builder is treated the same as no builder — the action will create a new docker-container builder in either case.

This is the same fix as #76 (credit to @dephiros), re-landed on a maintainer-owned branch so that CI can access the BUF registry token for the npm package fetch.

Note: dist/index.js will need to be rebuilt — CI has the BUF_TOKEN secret required to install dependencies and run the build. The verify-build check will flag this; a follow-up commit can update dist once CI confirms the source change is correct.


View Codesmith session


Open with Devin

adityamaru and others added 4 commits March 27, 2026 10:40
…cker driver

Co-authored-by: Codesmith <codesmith@blacksmith.sh>
Co-authored-by: Codesmith <codesmith@blacksmith.sh>
Co-authored-by: Codesmith <codesmith@blacksmith.sh>
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@adityamaru adityamaru merged commit 5241b2e into main Mar 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants