Skip to content

docs(readme): rewrite Quick Start, expand Skills tables, fix workflow#10

Merged
patdhlk merged 4 commits intomainfrom
docs/copilot-install
Apr 28, 2026
Merged

docs(readme): rewrite Quick Start, expand Skills tables, fix workflow#10
patdhlk merged 4 commits intomainfrom
docs/copilot-install

Conversation

@bburda
Copy link
Copy Markdown
Contributor

@bburda bburda commented Apr 28, 2026

Summary

Closes #8.

  • Replace fictional install commands with verified ones for both ecosystems:
    • Claude Code: /plugin marketplace add useblocks/pharaoh + /plugin install pharaoh@pharaoh-dev
    • Copilot CLI: copilot plugin marketplace add useblocks/pharaoh + copilot plugin install pharaoh@pharaoh-dev
  • Adopt the layout used by github/copilot-plugins (the official Copilot default marketplace): .github/plugin/marketplace.json is the source of truth and .claude-plugin/marketplace.json is a symlink (git mode 120000) pointing at it. Single source, no drift possible.
  • Document the asymmetric slash form: pharaoh's skills self-prefix in their own name (frontmatter name: pharaoh-setup), so the Claude Code invocation is /pharaoh:pharaoh-setup (doubled), while the Copilot agent files strip the redundant prefix and expose @pharaoh.setup.
  • Rewrite the Workflow diagram for plan-driven orchestration (pharaoh:pharaoh-write-plan + pharaoh:pharaoh-execute-plan); the previous diagram still showed the deleted composition-skill model.
  • Expand the Skills section from 24 to 71 entries across 8 categories: core workflow, plan-driven orchestration, atomic authoring/review chain, diagrams, feature reverse-engineering, analysis & audit, tailoring, setup utilities.
  • Fix three description drifts where README disagreed with the skill's SKILL.md (pharaoh-spec, pharaoh-flow, pharaoh-process-audit).
  • Fix dead sphinx-codelinks.useblocks.com URL → codelinks.useblocks.com.
  • Drop orphan [pharaoh.decisions] section from pharaoh.toml.example; no skill reads it.

Empirical verification

  • Pharaoh installed locally via both ecosystems on this branch's marketplace.json:
    • copilot plugin marketplace list shows pharaoh-dev (GitHub: useblocks/pharaoh)
    • copilot plugin list shows pharaoh@pharaoh-dev (v0.1.0)
    • ~/.claude/plugins/installed_plugins.json includes pharaoh@pharaoh-dev
  • All four invocation forms confirmed working: copilot plugin ..., gh copilot plugin ... (passthrough), /plugin install ..., /plugin marketplace add ....
  • All external links return HTTP 200.
  • Skill table count matches ls skills/ | grep -v shared | wc -l.

Test plan

  • Fresh copilot plugin marketplace add useblocks/pharaoh + copilot plugin install pharaoh@pharaoh-dev round-trip on a clean machine.
  • Fresh /plugin marketplace add useblocks/pharaoh + /plugin install pharaoh@pharaoh-dev + /reload-plugins in Claude Code.
  • Invoke one skill from each table category to confirm slash/at-mention forms resolve.
  • Verify symlink survives git clone on Windows (or document core.symlinks requirement if it does not).

- Replace fictional install commands with real /plugin (Claude Code) and
  copilot plugin (Copilot CLI) marketplace + install syntax. Both
  ecosystems can install pharaoh via the existing
  .claude-plugin/marketplace.json (Copilot also looks there).
- Mirror marketplace.json at .github/plugin/marketplace.json so Copilot
  users find it at the GitHub-native location. Add CI check enforcing
  the two files stay byte-identical.
- Rewrite the Workflow diagram to reflect plan-driven orchestration
  (pharaoh:write-plan + pharaoh:execute-plan) introduced in PR #9; the
  previous diagram still showed the deleted composition-skill model.
- Expand the Skills section from 24 to 71 entries, regrouped into 8
  categories: core workflow, plan-driven orchestration, atomic
  authoring/review, diagrams, feature reverse-engineering, analysis &
  audit, tailoring, setup utilities.
- Fix three description drifts (pharaoh:spec, pharaoh:flow,
  pharaoh:process-audit) where README disagreed with each skill's
  SKILL.md.
- Fix dead sphinx-codelinks URL (sphinx-codelinks.useblocks.com →
  codelinks.useblocks.com).
- Drop orphan [pharaoh.decisions] section from pharaoh.toml.example;
  no skill reads it.

Refs #8.
Copilot AI review requested due to automatic review settings April 28, 2026 11:37
@bburda bburda marked this pull request as draft April 28, 2026 11:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Pharaoh’s documentation and CI to reflect the current plugin installation flow and the plan-driven orchestration model, while expanding the public skill catalog and adding a mirrored marketplace manifest for GitHub Copilot.

Changes:

  • Rewrites README Quick Start and Workflow sections for marketplace-based installs and write-plan/execute-plan orchestration.
  • Expands the README Skills / Agents tables to cover the full current skill set and updates a dead codelinks URL.
  • Adds .github/plugin/marketplace.json and a CI check to enforce it stays byte-identical with .claude-plugin/marketplace.json; removes the unused [pharaoh.decisions] section from pharaoh.toml.example.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
README.md Updates install instructions, workflow diagram, skills tables, and fixes a codelinks URL.
pharaoh.toml.example Removes the orphan [pharaoh.decisions] section.
.github/workflows/ci.yaml Adds a CI step to ensure marketplace manifests remain identical.
.github/plugin/marketplace.json Adds a GitHub-native copy of the plugin marketplace manifest.

Comment thread README.md Outdated
Comment thread README.md Outdated
bburda added 2 commits April 28, 2026 13:50
Pharaoh's skill names already include the `pharaoh-` prefix (e.g.
SKILL.md frontmatter `name: pharaoh-setup`), so the Claude Code slash
namespace lands on `/pharaoh:pharaoh-setup`, not `/pharaoh:setup`.

Verified against the installed plugin: chrome-devtools-mcp's skills are
named cleanly (`troubleshooting` -> `/chrome-devtools-mcp:troubleshooting`),
while pharaoh and papyrus self-prefix (`pharaoh-setup` -> `/pharaoh:pharaoh-setup`).

The Copilot side already strips the prefix in agent file names
(`.github/agents/pharaoh.setup.agent.md` -> `@pharaoh.setup`), so the
two ecosystems address skills asymmetrically. README now documents the
asymmetry up front and uses the Claude Code form throughout the tables
and Quick Start.
Adopt the layout used by github/copilot-plugins (the official Copilot
default marketplace): .github/plugin/marketplace.json is the source of
truth, .claude-plugin/marketplace.json is a symlink (git mode 120000)
to ../.github/plugin/marketplace.json.

This keeps a single source of truth -- both Claude Code (which checks
.claude-plugin/) and Copilot CLI (which prefers .github/plugin/) find
the same file with no drift possible. Drops the CI diff check that was
guarding against the previous duplicate-file approach.
@bburda bburda requested a review from Copilot April 28, 2026 12:12
@bburda bburda self-assigned this Apr 28, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread .github/plugin/marketplace.json
- s/Analyse/Analyze/ in pharaoh:change row to match Quick Start's
  variant ("Analyze the impact of a change") used elsewhere in the doc.
- Workflow section now correctly describes pharaoh:pharaoh-write-plan
  as a pure transformation that returns plan.yaml content as text. The
  previous wording said it "emits .pharaoh/plans/<intent>.yaml", which
  contradicts the skill's SKILL.md ("Pure transformation: intent +
  project state -> plan text. Does not write artefacts. Does not mutate
  .pharaoh/."). The caller saves the YAML and hands the path to
  pharaoh:pharaoh-execute-plan.
@bburda bburda marked this pull request as ready for review April 28, 2026 13:37
Copy link
Copy Markdown
Collaborator

@patdhlk patdhlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@patdhlk patdhlk merged commit a6d11ae into main Apr 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pharaoh on vs code market place

3 participants