Add macOS and Windows code signing to release workflow#6
Open
Add macOS and Windows code signing to release workflow#6
Conversation
|
|
- Sign and notarize macOS binaries using Apple Developer ID certificate - Sign Windows binaries using a PFX certificate via signtool - All signing steps are skipped gracefully if secrets are not configured
03c6fb2 to
c1a986c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds code signing steps to the release pipeline for macOS and Windows binaries. macOS binaries are signed with a Developer ID certificate and notarized via Apple's notarization service. Windows binaries are signed with a PFX certificate via signtool. Both steps are skipped gracefully if secrets aren't configured.
Why
Without signing, macOS Gatekeeper and Windows SmartScreen block or warn users when running Bridge binaries. Closes internal ticket.
Checklist
cargo testpassescargo fmt --checkpassescargo clippypasses