Skip to content

Add macOS and Windows code signing to release workflow#6

Open
tomerlir wants to merge 2 commits intomainfrom
add-binary-signing
Open

Add macOS and Windows code signing to release workflow#6
tomerlir wants to merge 2 commits intomainfrom
add-binary-signing

Conversation

@tomerlir
Copy link
Copy Markdown
Contributor

What

Adds code signing steps to the release pipeline for macOS and Windows binaries. macOS binaries are signed with a Developer ID certificate and notarized via Apple's notarization service. Windows binaries are signed with a PFX certificate via signtool. Both steps are skipped gracefully if secrets aren't configured.

Why

Without signing, macOS Gatekeeper and Windows SmartScreen block or warn users when running Bridge binaries. Closes internal ticket.

Checklist

  • I have signed the CLA (first-time contributors)
  • Tests added or updated
  • cargo test passes
  • cargo fmt --check passes
  • cargo clippy passes

@tomerlir tomerlir requested a review from gbeslic as a code owner April 12, 2026 07:24
@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Apr 12, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Apr 12, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

- Sign and notarize macOS binaries using Apple Developer ID certificate
- Sign Windows binaries using a PFX certificate via signtool
- All signing steps are skipped gracefully if secrets are not configured
@tomerlir tomerlir force-pushed the add-binary-signing branch from 03c6fb2 to c1a986c Compare April 12, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant