Local development detection uses isPackaged flag #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its-treason
added a commit
to Its-treason/bruno
that referenced
this pull request
Mar 2, 2024
|
Would love to see this merged 👌 |
|
Also having problems with the linked issue here. |
Its-treason
approved these changes
Jul 24, 2024
pietrygamat
reviewed
Jul 24, 2024
| @@ -1,5 +1,4 @@ | |||
| const path = require('path'); | |||
| const isDev = require('electron-is-dev'); | |||
Contributor
There was a problem hiding this comment.
Does that mean the dependency can be removed from package.json?
Member
There was a problem hiding this comment.
Yes, but this wouldn't change much, because electron-is-dev is also required by electron-util
Author
There was a problem hiding this comment.
I'm all for maintaining a clean package.json!
Removed the now (in packages/bruno-electron) redundant package and updated the lockfile.
It seems like there's more changes in the lockfile than I expected:
@n8n/vm2wasn't tracked and now ispackages/bruno-electronreceived a version bump- a bunch of "dev": true lock flags disappeared - I honestly don't know how that relates to my change
helloanoop
requested review from
helloanoop,
lohit-bruno,
maintainer-bruno and
naman-bruno
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1253
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.