Skip to content

Conversation

@camflan
Copy link

@camflan camflan commented Jan 5, 2024

Description

Change to use "Mod" so that the modifier is platform specific. Binding to both cmd and control was causing conflicts with some platform-native functionality such as ctrl-f to move the cursor forward in a text field on mac OS.

Breaking changes:

  • Technically a breaking change because we're removing some keymappings that users may have been using

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Fixes #1337

@camflan camflan changed the title bugfix/[greedy keybindings]: Don't duplicate key bindings fix(#1337): Don't duplicate key bindings Jan 5, 2024
@camflan
Copy link
Author

camflan commented Mar 11, 2024

Bumpity bump

@camflan
Copy link
Author

camflan commented Mar 18, 2024

@helloanoop Hey, I'd love to get this in :)

@neecholaus
Copy link

I run into ctrl+f not moving the cursor forward on a daily basis. Would be great to get this resolved.

@jaffee
Copy link

jaffee commented Oct 8, 2024

Would love to see this merged, C-f not working to move the cursor around is my number one source of existential distress.

@naman-bruno
Copy link
Collaborator

Hey @camflan, Thanks for taking time to contribute, this has already been fixed in the latest version.
Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Key bindings are too greedy

7 participants