-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(#263): Implement script- & test-runtime in node:vm #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
84f340a to
7912e10
Compare
Due to changes in usebruno#650 collection variables would be passed as a object but was exptected to be an array. Collection variables are now converted to an array.
9bc11f1 to
e528a2f
Compare
|
is it possible that we can get this merged? |
|
@helloanoop is there anything I can do to get this one merged in? |
|
@helloanoop @lohxt1 is it possible to prioritise review of this pull request to help unblock our team ? If you can share timelines when your team will be able review will also help us plan migrate to Bruno. Cc: @Its-treason |
|
@Its-treason We are prioritising Node VM support to be worked on. Let us know if you'd have time to fix the conflicts and update the PR ? |
|
Sure, I would then migrate my updated implemented from: https://github.com/Its-treason/bruno/blob/lazer/packages/bruno-core/src/request/runtime/script-runner.ts If this implementation looks good to you. Should I leave the |
|
Hey @Its-treason That sounds good. Please also remove the readme related changes in the PR. We still want to keep the vm2 code around in the runtime files for now. |
|
@helloanoop I updated the PR. I'm not sure about the latest developments with the testing runtime etc. but I guess you want to update this PR anyway, so I leave the rest to you. Furthermore, I left some |
|
@Its-treason We made some more changes on top of your PR here and has been merged. We are releasing it in our upcoming version |
Description
Closes: #263 & #922
Implemented the existing script- & test-runtime with
node:vmto deprecatevm2. All runtimes are now combined in one file / function, because the other three runtimes before shared a lot of same code.If you want to test this locally, you have to manually activate the runtime by changing the hard-coded
if (false)to true, so it uses the new runtime.Test collection for anyone wanting to try / test it:
https://cdn.discordapp.com/attachments/1036297730483564687/1227724527752974336/VM-Test.zip?ex=66297291&is=6616fd91&hm=63637d55a57c17b3b2fff3ca34d9b17bdcd0deb734a0d685f64b17bab21bd464&