Skip to content

Conversation

@lucasmbrute2
Copy link

@lucasmbrute2 lucasmbrute2 commented Mar 3, 2024

Description

Increase clickable area in request tabs, wich improve UX

I noticed that padding top/bottom inside the li elements in RequestTabs component wasn't being used, decreasing the clickable area inside RequestTab component, it impacts direcly the new feature of closing tabs with middle mouse button. I removed this unnecessary padding and border. I did also move the entire logic to close tabs with mouse 1 to the function handleMouseUp. Video demo shows the middle mouse button being effetive in the entire tab, which is possible only after remove the padding and border.

issue: #1715

with-cliclabke-corner

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@lucasmbrute2 lucasmbrute2 changed the title Feat: increase clickable area to request tabs Feat: increase clickable area in request tabs Mar 4, 2024
@lucasmbrute2 lucasmbrute2 changed the title Feat: increase clickable area in request tabs feat(#1715): increase clickable area in request tabs Mar 4, 2024
@sswarren
Copy link

sswarren commented Mar 7, 2024

Changing padding seems fine, but the the demo video appears to be closing the tab every time you click on it. Hoping that is not part of the change. I don't know how to reconcile the behavior I think I see with your change description.

@lucasmbrute2
Copy link
Author

Changing padding seems fine, but the the demo video appears to be closing the tab every time you click on it. Hoping that is not part of the change. I don't know how to reconcile the behavior I think I see with your change description.

I noticed that the demo video is not enough clear, will record another one. The behavior is: whenever you click in tab with middle mouse button, it should close, even clicking in corners. The default behavior of the tabs didn't change.

@helloanoop helloanoop self-assigned this Sep 23, 2024
@FreeWall
Copy link

Will it be merged in the near future? It's really annoying to not able to close the tab with the middle mouse button, especially on Linux where it inserts the clipboard content into URL query input instead.

@naman-bruno
Copy link
Collaborator

Hey @lucasmbrute2 , thanks for taking the time to contribute!
This issue has already been resolved in the latest version.
Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants