feat(#1715): increase clickable area in request tabs #1716
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase clickable area in request tabs, wich improve UX
I noticed that padding top/bottom inside the li elements in RequestTabs component wasn't being used, decreasing the clickable area inside RequestTab component, it impacts direcly the new feature of closing tabs with middle mouse button. I removed this unnecessary padding and border. I did also move the entire logic to close tabs with mouse 1 to the function handleMouseUp. Video demo shows the middle mouse button being effetive in the entire tab, which is possible only after remove the padding and border.
issue: #1715
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.