[Bug] Using a / in an Environment Name causes error in Postman Import #1761 #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR fix the bug #1761 Could it be merged please? |
| }; | ||
|
|
||
| const importPostmanEnvironment = (environment) => { | ||
| const sanitizedEnvironmentName = environment.name.replace(/\//g, '_'); |
There was a problem hiding this comment.
This will not work for Some / Environment / Name as it'll result in Some _ Environment / Name, also there are more forbidden characters.
Any character that makes an invalid file name will throw an exception (/ for Windows, but Unix-based systems have more symbols).
Pragadesh44-Bruno
changed the title
Collaborator
|
Hey @ialloyd , thank you for raising this PR. In our latest versions, we have fixed the same bug you mentioned. If there are any invalid characters in the environment filename, they will be replaced with a “-”. Recording.at.2025-06-04.21.47.23.mp4 |
helloanoop
requested review from
helloanoop,
lohit-bruno,
maintainer-bruno and
naman-bruno
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that caused environment import to fail if the name contained a /. The importPostmanEnvironment function now replaces / with _ in environment names, allowing successful import.