feat: updated global error boundary, added error boundary for codeeditor, singleline editor, multiline editor #3166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor, singleline editor, multiline editor
lohxt1
changed the title
helloanoop
requested review from
helloanoop,
lohit-bruno,
maintainer-bruno and
naman-bruno
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~ updated the global error boundary component logic to reset the app
[ reset redux state, reset watcher, open the lastOpenedCollections ]
~ added component level error boundary for codeeditor, singleline editor and multiline editor components
before:
global error
global_error.mov
after:
global error - reset app
global_error_reset_app.mov
component level error boundary
component_level_error_boundary.mov