Skip to content

Conversation

@chenrui333
Copy link

Description

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.


fixes #2229
relates to Homebrew/homebrew-core#200885

Signed-off-by: Rui Chen <rui@chenrui.dev>
@helloanoop helloanoop self-assigned this Jan 13, 2025
@nmss
Copy link

nmss commented Feb 17, 2025

Wouldn't it be better to address the deprecation and remove/replace punycode instead of hiding the warning message ?

https://nodejs.org/api/punycode.html#punycode

The version of the punycode module bundled in Node.js is being deprecated. In a future major version of Node.js this module will be removed. Users currently depending on the punycode module should switch to using the userland-provided Punycode.js module instead. For punycode-based URL encoding, see url.domainToASCII or, more generally, the WHATWG URL API.

@pieterocp
Copy link
Contributor

@nmss it'd be better, but suppression is one way to fix it in the short term, this does stop consumers of the cli from having to see it. We probably want to go with a better fix involving slight internal changes and probably upgrades of dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bruno CLI: The punycode module is deprecated

4 participants