fix: allow node core modules in developer mode #3768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramki-bruno
reviewed
Jan 17, 2025
| sandbox: context, | ||
| require: { | ||
| context: 'sandbox', | ||
| builtin: [ "*" ], |
Contributor
There was a problem hiding this comment.
maybe only if allowScriptFilesystemAccess is set? similar to how its done for the fs builtin-module?
ramki-bruno
reviewed
Jan 17, 2025
| builtin: [ "*" ], | ||
| external: true, | ||
| root: [collectionPath, ...additionalContextRootsAbsolute], | ||
| mock: { |
Contributor
There was a problem hiding this comment.
Note related to this PR. @helloanoop any reason why we use mock instead of external? for adding the default libs?
Pragadesh-45
approved these changes
Mar 6, 2025
helloanoop
requested review from
lohit-bruno,
maintainer-bruno and
naman-bruno
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~ enables usage of node's core modules in developer mode