fix(bruno-lang): Fix multiline text blocks in multipart form #4619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons in .bru files This change enhances the Bruno language parser to properly handle multiline text blocks (delimited with triple quotes) in multipart form fields that include content type annotations. Improvements: - Update grammar definition to correctly recognize multiline blocks with @ContentType annotations - Enhanced multipartExtractContentType function to properly extract content and type annotations - Added indentation handling to preserve proper structure while removing common indentation - Updated the test cases to address this scenario. This fixes the multipart form data parsing issue when using multiline text with content type annotations.
5 tasks
helloanoop
requested review from
helloanoop,
lohit-bruno,
maintainer-bruno and
naman-bruno
as code owners
Collaborator
|
Hey @me-manikanta We’ve merged an alternative solution (#6217) that is cleaner, and better aligned with our long-term maintainability goals, so I’ll be closing this one. Really appreciate the effort you put into this — and I hope to see more contributions from you in the future! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change enhances the Bruno language parser to properly handle multiline text blocks (delimited with triple quotes) in multipart form fields that include content type annotations.
Improvements:
This fixes the multipart form data parsing issue when using multiline text with content type annotations.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
#4457