Skip to content

fix: autosave playwright test#7641

Merged
bijin-bruno merged 2 commits intousebruno:mainfrom
pooja-bruno:fix/autosave-playwright-test
Apr 1, 2026
Merged

fix: autosave playwright test#7641
bijin-bruno merged 2 commits intousebruno:mainfrom
pooja-bruno:fix/autosave-playwright-test

Conversation

@pooja-bruno
Copy link
Copy Markdown
Collaborator

@pooja-bruno pooja-bruno commented Apr 1, 2026

Description

Use platform-aware save shortcut in autosave tests

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Tests
    • Updated test suites to use a platform-appropriate save keyboard shortcut across multiple scenarios, improving test reliability and cross-OS consistency.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cc665666-e331-431d-8a75-a6e5c7db7971

📥 Commits

Reviewing files that changed from the base of the PR and between 5b1d4d0 and 91373f4.

📒 Files selected for processing (2)
  • tests/request/headers/header-validation.spec.ts
  • tests/variable-tooltip/variable-tooltip.spec.ts

Walkthrough

Replaced hardcoded Control+s keystrokes in tests with a platform-aware saveShortcut constant (Meta+s on macOS, Control+s elsewhere) across multiple test specs to trigger saves using the appropriate OS keyboard chord.

Changes

Cohort / File(s) Summary
Platform-specific Save Shortcut
tests/preferences/autosave/autosave.spec.ts, tests/request/headers/header-validation.spec.ts, tests/variable-tooltip/variable-tooltip.spec.ts
Added a saveShortcut constant based on process.platform and replaced direct page.keyboard.press('Control+s') calls with page.keyboard.press(saveShortcut) to use Meta+s on macOS and Control+s on other platforms.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

size/XS

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • naman-bruno

Poem

Keys change with the platform's mood,
Meta for Mac, Control where it's crude.
Tests now press the proper chord,
One small constant, one shared word,
Cross-OS harmony, neatly stewed. 🎹

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: autosave playwright test' is partially related to the changeset—it mentions autosave tests, but the actual changes address a broader issue: making keyboard shortcuts platform-aware across three separate test files. Consider a more specific title like 'fix: use platform-aware save shortcuts in playwright tests' to better reflect the cross-file platform compatibility changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pull-request-size pull-request-size Bot added size/M and removed size/XS labels Apr 1, 2026
@bijin-bruno bijin-bruno merged commit aa7b8f4 into usebruno:main Apr 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants