Skip to content

fix/search bar in codeeditor#7841

Merged
sid-bruno merged 2 commits into
usebruno:mainfrom
shubh-bruno:fix/keybindings-patch
Apr 27, 2026
Merged

fix/search bar in codeeditor#7841
sid-bruno merged 2 commits into
usebruno:mainfrom
shubh-bruno:fix/keybindings-patch

Conversation

@shubh-bruno
Copy link
Copy Markdown
Collaborator

@shubh-bruno shubh-bruno commented Apr 23, 2026

Description

JIRA

Fixes: #7833

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Bug Fixes

    • Sidebar search keyboard shortcut now properly respects focus within the code editor, preventing accidental triggering while editing.
  • Refactor

    • Reorganized keyboard shortcut binding logic for sidebar search functionality across components.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3d6e52f0-7885-4c3e-9a09-867e89faae38

📥 Commits

Reviewing files that changed from the base of the PR and between e12b736 and 88dcf9a.

📒 Files selected for processing (2)
  • packages/bruno-app/src/components/Sidebar/index.js
  • packages/bruno-app/src/providers/Hotkeys/index.js

Walkthrough

The sidebarSearch keyboard binding is being relocated from the centralized Hotkeys provider to the Sidebar component itself. The binding now uses a useKeybinding hook and includes logic to skip execution when the CodeMirror editor is in focus, allowing the editor's native Find behavior to take precedence.

Changes

Cohort / File(s) Summary
Sidebar Search Keybinding Relocation
packages/bruno-app/src/components/Sidebar/index.js, packages/bruno-app/src/providers/Hotkeys/index.js
Moves sidebarSearch keyboard binding from centralized Hotkeys provider to Sidebar component using useKeybinding hook. Added context check to bypass keybinding when CodeMirror editor is active; removed binding from provider.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

size/M

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • sid-bruno
  • bijin-bruno

Poem

🔑 From the provider's grand hall to the sidebar's cozy home,
The search shortcut wandered, no longer alone,
With CodeMirror's wisdom—respect when it's near,
A keybinding journey, now crystal clear! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix/search bar in codeeditor' refers to a real aspect of the changeset (moving sidebarSearch keybinding logic from the hotkey provider to the Sidebar component, with CodeMirror editor awareness), but doesn't clearly convey the primary change or its purpose. Consider a more descriptive title like 'Move sidebarSearch keybinding to Sidebar component with CodeMirror awareness' that better explains the refactoring and its intent.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sid-bruno sid-bruno merged commit 9361393 into usebruno:main Apr 27, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ctrl-F opens Collection search input even if focus is in message body

2 participants