chore(lint): warn on redundant closures for method calls

Cargo.toml

@@ -63,6 +63,7 @@ panic = "warn"
 cloned_instead_of_copied = "warn"
 implicit_clone = "warn"
 needless_pass_by_value = "warn"
+redundant_closure_for_method_calls = "warn"
 
 [profile.dist]
 inherits = "release"

src/api/client.rs

@@ -3,6 +3,8 @@ use std::time::Duration;
 use anyhow::{Context, Result};
 use reqwest::header::{HeaderMap, AUTHORIZATION};
 
+use progenitor::progenitor_client::ResponseValue;
+
 use super::types::*;
 
 pub struct ApiClient {
@@ -38,7 +40,7 @@ impl ApiClient {
         self.inner
             .get_public_user()
             .await
-            .map(|r| r.into_inner())
+            .map(ResponseValue::into_inner)
             .map_err(|e| anyhow::anyhow!("API error: {}", e))
     }
 
@@ -59,15 +61,15 @@ impl ApiClient {
                 status,
             )
             .await
-            .map(|r| r.into_inner())
+            .map(ResponseValue::into_inner)
             .map_err(|e| anyhow::anyhow!("API error: {}", e))
     }
 
     pub async fn get_bug(&self, bug_id: &BugId) -> Result<Bug> {
         self.inner
             .get_public_bug(bug_id)
             .await
-            .map(|r| r.into_inner())
+            .map(ResponseValue::into_inner)
             .map_err(|e| anyhow::anyhow!("API error: {}", e))
     }
 
@@ -87,7 +89,7 @@ impl ApiClient {
         self.inner
             .create_public_bug_review(bug_id, &body)
             .await
-            .map(|r| r.into_inner())
+            .map(ResponseValue::into_inner)
             .map_err(|e| anyhow::anyhow!("API error: {}", e))
     }
 
@@ -97,7 +99,7 @@ impl ApiClient {
         self.inner
             .list_public_repos(NonZeroU64::new(limit.into()), Some(offset.into()))
             .await
-            .map(|r| r.into_inner())
+            .map(ResponseValue::into_inner)
             .map_err(|e| anyhow::anyhow!("API error: {}", e))
     }
 }

src/upgrade.rs

@@ -22,7 +22,7 @@ fn version_strings(result: &UpdateResult) -> (String, String) {
     let old_version = result
         .old_version
         .as_ref()
-        .map(|v| v.to_string())
+        .map(ToString::to_string)
         .unwrap_or_else(|| "unknown".to_string());
     let new_version = result.new_version.to_string();
     (old_version, new_version)