fix: don't crash server when a non HTTP method was provided#236
Merged
fix: don't crash server when a non HTTP method was provided#236
Conversation
tomhgmns
approved these changes
May 14, 2023
AbelVandenBriel
approved these changes
May 14, 2023
Contributor
AbelVandenBriel
left a comment
AbelVandenBriel
left a comment
There was a problem hiding this comment.
I just realised: what happens with an empty string method? Is it possible, if so, how does this handle it?
Member
Author
This would still crash the server. But afaik this is literally impossible cause we are using node http's built in request streams for this. An empty method is not possible. (link to node http IncomingMessage doc) |
lem-onade
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR