Skip to content

Conversation

@hyoban
Copy link
Contributor

@hyoban hyoban commented Jul 6, 2022

showing memos without logging in can let us use it like a personal Twitter.

@boojack
Copy link
Member

boojack commented Jul 6, 2022

I think it's better to create a new page to show someone's public memos. Just like https://jike.city/xidong, wdyt?

@hyoban
Copy link
Contributor Author

hyoban commented Jul 6, 2022

My idea is to make it like Github, others can see what's public by default, and at the same time, we can hide some memos.
The page seen by visitors and owners is the same.

@boojack
Copy link
Member

boojack commented Jul 6, 2022

But the current main page UI isn't good for visitor because of the editor and some action buttons. A new pure page to display public memos and some extra information might be better for viewer.

@boojack
Copy link
Member

boojack commented Jul 6, 2022

But the current main page UI isn't good for visitor because of the editor and some action buttons. A new pure page to display public memos and some extra information might be better for viewer.

After taking a deep look, I think it's good for viewing when hiding some extra elements.

image

@hyoban
Copy link
Contributor Author

hyoban commented Jul 6, 2022

In the draft pr, I hide some components based on user state
This is what it looks like now.
image

@boojack
Copy link
Member

boojack commented Jul 6, 2022

LGTM. Another question: it looks like we can only view the owner's memos, so how do we view other member's memos?

@hyoban
Copy link
Contributor Author

hyoban commented Jul 6, 2022

This is also a more troublesome issue that I have considered. At present, I let it display the owner's memos by default.

@hyoban
Copy link
Contributor Author

hyoban commented Jul 6, 2022

I think most people will choose to build their own memos.
Allowing multiple users to be created doesn't seem very useful.

@boojack
Copy link
Member

boojack commented Jul 6, 2022

We can add a "/:userId" route in frontend, and both of "/", "/:userId" will render the Home page. When hit the "/:userId", the stored user will be fetching with it.

But as you says,

I think most people will choose to build their own memos. Allowing multiple users to be created doesn't seem very useful.

always show the owner's memos is fine in this PR.

@hyoban
Copy link
Contributor Author

hyoban commented Jul 6, 2022

ok, I'll try to handle each user's homepage

@hyoban
Copy link
Contributor Author

hyoban commented Jul 6, 2022

@boojack maybe you can review the code when you are free

@hyoban
Copy link
Contributor Author

hyoban commented Jul 6, 2022

Thanks for your review, I will revise it asap

@hyoban hyoban marked this pull request as ready for review July 6, 2022 23:29
@hyoban hyoban requested a review from lqwakeup as a code owner July 6, 2022 23:29
@hyoban hyoban requested a review from boojack July 6, 2022 23:40
@hyoban hyoban requested a review from boojack July 7, 2022 05:46
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, some nits.

@boojack boojack changed the title feat: no need to log in to view memos feat: personal memos page Jul 7, 2022
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 6b5d5e7 into usememos:main Jul 7, 2022
@hyoban
Copy link
Contributor Author

hyoban commented Jul 7, 2022

This is my first contribution to a little feat, I have learned a lot, thank you @boojack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants