-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat: personal memos page #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think it's better to create a new page to show someone's public memos. Just like https://jike.city/xidong, wdyt? |
|
My idea is to make it like Github, others can see what's public by default, and at the same time, we can hide some memos. |
|
But the current main page UI isn't good for visitor because of the editor and some action buttons. A new pure page to display public memos and some extra information might be better for viewer. |
|
LGTM. Another question: it looks like we can only view the owner's memos, so how do we view other member's memos? |
|
This is also a more troublesome issue that I have considered. At present, I let it display the owner's memos by default. |
|
I think most people will choose to build their own memos. |
|
We can add a "/:userId" route in frontend, and both of "/", "/:userId" will render the But as you says,
always show the owner's memos is fine in this PR. |
|
ok, I'll try to handle each user's homepage |
|
@boojack maybe you can review the code when you are free |
|
Thanks for your review, I will revise it asap |
boojack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, some nits.
boojack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This is my first contribution to a little feat, I have learned a lot, thank you @boojack |


showing memos without logging in can let us use it like a personal Twitter.