Conversation
|
@PredictiveManish is attempting to deploy a commit to the Moss Team Team on Vercel. A member of the Team first needs to authorize it. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Thanks @PredictiveManish! Good expansion of test coverage on the resolveId, load, and character escaping paths. |
|
@PredictiveManish @HarshaNalluru I think its good to go, just vitepress CI is failing can you please fix that @PredictiveManish ? |
Sure will do it very soon. |
|
Is this ready for review ? |
Facing some test issues, when solved will tag for merging. |
PredictiveManish
left a comment
There was a problem hiding this comment.
@HarshaNalluru I have a small query that Why after commiting, it doesn't automatically runs all the tests? Like I've observed that when someone from maintainers comments or review anything only after that comment or review it runs all the tests and shows failures/passed is this some kind of workflow or anything else?
|
Hi @PredictiveManish , we have recently enabled test workflows for all. Please let me know if you have any questions. |
|
@PredictiveManish, Please let me know if you are still working this. |
Yeah, sorry for the delay actually was busy with a hackathon. It's over will work on this to fix the remaining bugs. |
…unit-tests-vitepress
…anish/moss into unit-tests-vitepress
|
@yatharthk2 I think it's now fixed, let me know if there's any other thing you see wrong here. |
Summary:
Add comprehensive unit tests for the vitepress-plugin-moss package, expanding test coverage from 5 to 45 tests covering the core plugin functionality. This ensures reliability and maintainability of the plugin.
Please ensure that your PR meets the following requirements:
Description
Test File Expanded
tests/index.test.ts- Expanded from 5 to 45 testsresolveId - virtual moduleresolveId - component shadowingload - config loadingbuildEnd - index synccloseBundleplugin metadataKey Test Coverage
<,>,/,\,\n,\r,\t,\0,\b,\f,\u2028,\u2029)Fixes #45
Type of Change