Add support for Import Statements by matthias-mar · Pull Request #107 · useocl/use

matthias-mar · 2025-05-22T15:06:08Z

No description provided.

ichxorya · 2025-05-22T15:21:36Z

Very cool feature! Hopefully this can be reviewed and merged into the code base.

…ed elements via model qualifier, integration tests for imported models

matthias-mar · 2025-06-10T11:24:24Z

Changes:

Added dedicated file path during compilation, since imports rely on well-formed file paths to locate imported specifications
Introduced model qualifier concept:
- Users can import elements using their model name as a qualifier (import modelName#elementName from "modelName.use"), to avoid name conflicts with duplicate element identifiers
- Uniqueness of identifiers is only guaranteed between a model and its direct imports, transitively imported elements must be accessed using the qualified name syntax (model A imports class B from model C, class B has attribute x with imported data type D from model E -> in order to assign a value to attribute x, the constructor must be called like !set b.x := E#D(1,1)
Added Shell integration tests for models with imports

h-man2

See comments

Please add dev documentation about the internals

h-man2 · 2025-06-13T07:14:06Z

use-core/src/main/java/org/tzi/use/parser/ocl/ASTOperationExpression.java


        // check for constructor call
-        MClassifier cf = ctx.model().getClassifier(opname);
+        MClassifier cf = srcClassifier.model() != null ? srcClassifier.model().getClassifier(opname)


Please clarify the reason behind the check.

Clarification added.

h-man2 · 2025-06-13T07:14:50Z

use-core/src/main/java/org/tzi/use/parser/ocl/ASTSimpleType.java

        fName = name;
    }

+    public Token getfName() {


Please remove f from name

I saw many f in the code base and still doesn't get the convention, do you know why there were f variables?

Removed f's from variable names.

h-man2 · 2025-06-13T07:16:24Z

use-core/src/main/java/org/tzi/use/parser/use/ASTImportStatement.java

+ * of external model files and their specified elements.
+ */
+public class ASTImportStatement extends AST {
+    private final List<String> fSymbols;


Please f from Name (old style).

Same here, removed f's from variable names.

h-man2 · 2025-06-13T07:17:12Z

use-core/src/main/java/org/tzi/use/parser/use/ASTModel.java

- * @author  Stefan Schoon
+ * @author Mark Richters
+ * @author Lars Hamann
+ * @author Stefan Schoon


Add @author

Authorship added to relevant classes.

h-man2 · 2025-06-17T08:00:17Z

It was an old prefix for "field" i.e. an instance variable.

…qualified element resolution

h-man2

LGTM 🔥

Add support for Import Statements

9c9920a

Add more robust file paths during model compilation, access to import…

4dd26e4

…ed elements via model qualifier, integration tests for imported models

Fix ClassDiagramView to also display imported elements

6822d48

h-man2 requested changes Jun 13, 2025

View reviewed changes

Rename variables, add copyright statement and authorship, fix bug in …

62850ea

…qualified element resolution

h-man2 approved these changes Jun 25, 2025

View reviewed changes

h-man2 merged commit 9c04e5e into useocl:master Jun 25, 2025

Conversation

matthias-mar commented May 22, 2025

Uh oh!

ichxorya commented May 22, 2025

Uh oh!

matthias-mar commented Jun 10, 2025

Uh oh!

h-man2 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

h-man2 commented Jun 17, 2025

Uh oh!

h-man2 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants