Fix NullPointerException in diagram layout methods#115
Merged
Conversation
- Fixed incorrect null check in 6 layout methods - Changed 'if (fLayouter == null)' to 'if (fAllLayoutTypes == null)' - Methods affected: HierarchicalLayout, HierarchicalUpsideDownLayout, HorizontalLayout, HorizontalRightToLeftLayout, LandscapeSwimlaneLayout, PortraitSwimlaneLayout - Resolves runtime error when calling layout methods on uninitialized diagrams Fixes: Diagram layout NullPointerException when fAllLayoutTypes is null
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a NullPointerException bug in diagram layout methods by correcting the null check condition. The issue was that six layout methods were checking fLayouter for null instead of fAllLayoutTypes, which caused runtime errors when attempting to layout uninitialized diagrams.
- Fixed null check condition in 6 layout methods from
fLayouter == nulltofAllLayoutTypes == null - Prevents NullPointerException when calling layout methods on uninitialized diagrams
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: Diagram layout NullPointerException when fAllLayoutTypes is null