feat: Major improvements by user-cube · Pull Request #30 · user-cube/cluster-bootstrap

user-cube · 2026-02-17T01:44:49Z

Improve status
Add validate
Add doctor
Add health checks
Idempotent design
Output format
Template command
Update docs

Copilot

Pull request overview

This pull request introduces significant improvements to the cluster-bootstrap CLI tool, focusing on enhanced observability, validation, and idempotent operations. The changes add three new diagnostic commands (doctor, status, validate), implement comprehensive bootstrap reporting with multiple output formats, and refactor resource management functions to explicitly track whether resources are created or updated.

Changes:

Added three new CLI commands: doctor (tooling checks), status (cluster status alias for info), and validate (comprehensive validation of config, secrets, and cluster)
Implemented bootstrap reporting system with JSON and summary output formats, tracking stage timing, resource operations, and health checks
Refactored k8s and helm functions to return boolean flags indicating create vs. update operations for true idempotency
Changed k8s Client to use kubernetes.Interface instead of concrete type for better testability
Enhanced info command to display ArgoCD Applications with sync/health status
Updated documentation with detailed information about new commands, idempotent behavior, and reporting features

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
mkdocs.yml	Added navigation entries for new CLI commands and fixed indentation formatting
docs/cli/validate.md	Documentation for new validate command with flags and examples
docs/cli/status.md	Documentation for new status command (alias of info)
docs/cli/doctor.md	Documentation for new doctor command for prerequisite checks
docs/cli/index.md	Updated CLI overview with new commands
docs/cli/bootstrap.md	Added documentation for idempotent behavior and bootstrap reporting feature
README.md	Updated with idempotent design note, bootstrap reports section, and new commands in CLI table
cli/internal/k8s/secrets_test.go	New comprehensive tests for idempotent secret operations
cli/internal/k8s/secrets.go	Modified CreateRepoSSHSecret and CreateGitCryptKeySecret to return boolean indicating create vs update
cli/internal/k8s/client.go	Changed Clientset from concrete type to kubernetes.Interface for better testability
cli/internal/k8s/appofapps.go	Modified ApplyAppOfApps to return boolean indicating create vs update
cli/internal/helm/argocd.go	Modified InstallArgoCD to return boolean indicating install vs upgrade
cli/cmd/validate.go	New comprehensive validation command (490 lines) checking config, secrets, cluster, repo access
cli/cmd/status.go	New status command as alias for info command
cli/cmd/preflight.go	Added CheckKubectlClusterAccessWithConfig to support custom kubeconfig/context
cli/cmd/info.go	Enhanced to discover and display ArgoCD Applications with sync/health status; fixed prometheus selector
cli/cmd/gitcrypt_key.go	Updated to show "Created" vs "Updated" based on returned boolean
cli/cmd/doctor.go	New diagnostic command for checking local tools and cluster access
cli/cmd/bootstrap_report_test.go	Comprehensive tests for bootstrap reporting functionality
cli/cmd/bootstrap_report.go	New bootstrap reporting system with stage timing, resource tracking, and health status
cli/cmd/bootstrap.go	Integrated reporting system, tracking all stages and resource operations with create/update status

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ootstrap into feature/new-commands

Copilot

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ootstrap into feature/new-commands

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ootstrap into feature/new-commands

# [1.4.0](v1.3.1...v1.4.0) (2026-02-17) ### Bug Fixes * fix bypass rules ([79fdce9](79fdce9)) ### Features * fix bypass ([daa2e57](daa2e57)) * Major improvements ([#30](#30)) ([48e5775](48e5775))

user-cube added 5 commits February 17, 2026 01:16

feat: add doctor command

4c1d4ba

feat: add health checks

6e7c58f

feat: add validate

dde7485

feat: add validate

a6f4253

feat: improve status

f77f835

user-cube self-assigned this Feb 17, 2026

devopsbuddyapp bot added documentation Improvements or additions to documentation low-priority Auto-generated label for low-priority feature Auto-generated label for feature branches labels Feb 17, 2026

user-cube added 3 commits February 17, 2026 01:54

feat: improve status

18f6b00

feat: add output format

62cdf30

feat: add output format

bd9af4c

user-cube requested a review from Copilot February 17, 2026 02:08

Copilot started reviewing on behalf of user-cube February 17, 2026 02:08 View session

feat: template command

1167027

Copilot AI reviewed Feb 17, 2026

View reviewed changes

feat: fix linter

df95749

user-cube requested a review from Copilot February 17, 2026 02:18

Copilot started reviewing on behalf of user-cube February 17, 2026 02:18 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Comment thread cli/cmd/template.go

Comment thread cli/cmd/validate.go Outdated

Comment thread cli/cmd/bootstrap.go

Comment thread cli/cmd/template.go Outdated

user-cube and others added 3 commits February 17, 2026 02:23

feat: Update cli/internal/k8s/appofapps.go

cd8a676

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: Update cli/cmd/template.go

d9f17d4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: Update cli/cmd/info.go

ec405f5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Feb 17, 2026

feat: Clarify scope of file permissions fix in template.go #31

Closed

Repository owner deleted a comment from Copilot AI Feb 17, 2026

user-cube added 3 commits February 17, 2026 02:35

feat: fix pr comments

8ed9c82

Merge branch 'feature/new-commands' of github.com:user-cube/cluster-b…

3f68ed1

…ootstrap into feature/new-commands

feat: fix lint issues

4b42e9b

user-cube requested a review from Copilot February 17, 2026 02:39

Copilot started reviewing on behalf of user-cube February 17, 2026 02:39 View session

Copilot started reviewing on behalf of user-cube February 17, 2026 02:55 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Comment thread cli/cmd/template.go Outdated

Comment thread cli/cmd/template.go

Comment thread cli/cmd/template.go Outdated

Comment thread cli/cmd/bootstrap.go Outdated

user-cube and others added 5 commits February 17, 2026 03:00

feat: Update cli/cmd/template.go

3a8afe9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: Update cli/cmd/template.go

18808c3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: Update cli/cmd/bootstrap.go

372dc34

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into feature/new-commands

d07924b

feat: fix lint issues

a6133ae

user-cube requested a review from Copilot February 17, 2026 03:08

Copilot started reviewing on behalf of user-cube February 17, 2026 03:08 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Comment thread cli/internal/k8s/secrets_test.go Outdated

Comment thread cli/cmd/template.go

Comment thread cli/internal/k8s/client_mock.go

Comment thread cli/cmd/validate.go

Comment thread cli/internal/k8s/secrets_test.go Outdated

user-cube and others added 4 commits February 17, 2026 03:13

feat: Update cli/internal/k8s/secrets_test.go

e39855e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: Update cli/internal/k8s/secrets_test.go

e66f5e0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: fix tests

30653c0

Merge branch 'feature/new-commands' of github.com:user-cube/cluster-b…

552b73f

…ootstrap into feature/new-commands

user-cube requested a review from Copilot February 17, 2026 03:20

Copilot started reviewing on behalf of user-cube February 17, 2026 03:20 View session

user-cube added 2 commits February 17, 2026 03:21

feat: update go.sum

9dfba83

feat: fix tests

3577a3a

Copilot AI reviewed Feb 17, 2026

View reviewed changes

user-cube and others added 6 commits February 17, 2026 03:30

feat: Update cli/cmd/template.go

2ede935

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: Update cli/cmd/template.go

0c726ba

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: Update cli/cmd/template_test.go

f8822d9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: Update cli/cmd/validate.go

cdf1346

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'feature/new-commands' of github.com:user-cube/cluster-b…

ca4f2d6

…ootstrap into feature/new-commands

feat: fix tests

55c5ae8

user-cube enabled auto-merge (squash) February 17, 2026 03:45

user-cube disabled auto-merge February 17, 2026 03:46

user-cube merged commit 48e5775 into main Feb 17, 2026
8 checks passed

user-cube deleted the feature/new-commands branch February 17, 2026 03:46

Conversation

user-cube commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

user-cube commented Feb 17, 2026 •

edited

Loading