UIDS-24 Flash message components #25
Conversation
rsaris
left a comment
rsaris
left a comment
There was a problem hiding this comment.
Overall this looks good though I'd point out that this is a pretty new library so there is definitely stuff we still need to bring over and we should try and keep things as generic and reusable as we can. I have left comments where I think we can do that more.
I'll leave it to Dave to comment more on the stories and specs.
davidmferris
left a comment
davidmferris
left a comment
There was a problem hiding this comment.
Looking great so far! A few mostly minor comments for ya.
rroppolo
left a comment
rroppolo
left a comment
There was a problem hiding this comment.
Thanks for the review - back to you @rsaris @davidmferris !
davidmferris
left a comment
davidmferris
left a comment
There was a problem hiding this comment.
Looks awesome. Nice job @rroppolo
|
Sorry this review took so long -- @davidmferris and @rroppolo do you want to get a release together and get this working in the Rails app? |
For #24
Move flash message component into design system and include hook (and pass through HOC that uses the hook too) for better reusability in app components.