fix: CLI snapshot panic + at_time time format (fixes #180, #181)#182
Merged
Conversation
- Snapshot commands used get_arg(m, "symbols") but clap arg is "symbol" causing panic on every snapshot call. Fixed to "symbol". - at_time commands: server expects hh:mm:ss.SSS but users may pass milliseconds. Added normalize_time() that auto-converts ms to hh:mm:ss.SSS format. Both formats now accepted. Fixes #180, #181 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-existing CLI bugs found during live endpoint testing:
get_arg(m, "symbols")but clap arg registered as"symbol". Fixed.hh:mm:ss.SSSbut CLI passed raw milliseconds. Addednormalize_time()that auto-converts. Both34200000and09:30:00.000now work.Test plan (live, market open)
tdx stock snapshot_ohlc AAPL--open: 256.9625, close: 259.3901tdx stock snapshot_quote AAPL--bid: 259.38, ask: 259.42tdx stock at_time_trade AAPL 20260401 20260402 34200000-- ms format workstdx stock at_time_trade AAPL 20260401 20260402 09:30:00.000-- hh:mm:ss works🤖 Generated with Claude Code