Refactor examples #564
Merged
Refactor examples #564
+51
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
shoota
commented
May 16, 2018
| contentBase: path.join(__dirname, 'build'), | ||
| openPage: '/simple/' | ||
| openPage: '/simple/', | ||
| publicPath: '/agent.js/' |
Contributor
Author
There was a problem hiding this comment.
gh-page path has /agent.js
shoota
commented
May 16, 2018
| "release": "lerna exec --bail=false -- 'can-npm-publish && npm publish'", | ||
| "start": "concurrently -k 'yarn w:examples' 'yarn w:website' 'yarn w:html'", | ||
| "test": "karma start", | ||
| "w:examples": "webpack-dev-server --config examples/webpack.config.ts --output-path examples/build/assets --env production", |
shoota
commented
May 16, 2018
| "w:examples": "webpack-dev-server --config examples/webpack.config.ts --output-path examples/build/assets --env production", | ||
| "w:html": "pug examples -o examples/build -P -s -w", | ||
| "w:examples": "webpack-dev-server --config examples/webpack.config.ts --env production", | ||
| "w:html": "pug examples -o examples/build/agent.js -P -s -w", |
Contributor
Author
There was a problem hiding this comment.
fix with webpack-dev-server
Contributor
|
Blogのリンクが404になるのはOKなんでしたっけ？ |
shkumagai
previously approved these changes
May 16, 2018
Surgo
reviewed
May 16, 2018
examples/built-in/index.pug
Outdated
| include:markdown-it README.md | ||
|
|
||
| block breadcrumb-current | ||
| li.active use with nodejs |
Surgo
approved these changes
May 16, 2018
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 19 19
Lines 550 550
Branches 97 97
=======================================
Hits 504 504
Misses 25 25
Partials 21 21 |
dkimura
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
check this pr
How to check
Check list
yarn e2efinished with success.