Skip to content

Fix/crowdin install #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shkumagai merged 2 commits into from
Jul 9, 2018
Merged

Fix/crowdin install #732

shkumagai merged 2 commits into from
Jul 9, 2018

Conversation

@shoota
Copy link
Contributor

@shoota shoota commented Jul 9, 2018

TL;DR

fix travis install error

W: GPG error: https://artifacts.crowdin.com/repo/deb  Release: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 258533FA9C3C1ABC
W: The repository 'https://artifacts.crowdin.com/repo/deb  Release' is not signed.
W: There is no public key available for the following key IDs:
258533FA9C3C1ABC

Check this pr.

Check list

  • crowdin install success and pass deploy stage in travis CI.

@ghost ghost assigned shoota Jul 9, 2018
@ghost ghost added the in progress label Jul 9, 2018
@codecov
Copy link

codecov bot commented Jul 9, 2018

Codecov Report

Merging #732 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #732   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files          23       23           
  Lines         592      592           
  Branches      103      103           
=======================================
  Hits          541      541           
  Misses         27       27           
  Partials       24       24

@shoota shoota added QA and removed in progress labels Jul 9, 2018
usaturn
usaturn approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@usaturn usaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shoota
shoota commented Jul 9, 2018
View reviewed changes
.travis.yml
fi
npm run ci:sauce
- stage: deploy
addons:
Copy link
Contributor Author

@shoota shoota Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial revert
https://github.com/userdive/agent.js/pull/675/files#diff-354f30a63fb0907d4ad57269548329e3R50

shkumagai
shkumagai approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@shkumagai shkumagai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shkumagai shkumagai merged commit 5998dda into master Jul 9, 2018
@ghost ghost removed the QA label Jul 9, 2018
@shkumagai shkumagai deleted the fix/crowdin_install branch July 9, 2018 01:43
@shoota shoota mentioned this pull request Jul 24, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@shkumagai shkumagai shkumagai approved these changes

@usaturn usaturn usaturn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shoota shoota

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shoota @shkumagai @usaturn