Fix karma-fixture #735
Merged
Fix karma-fixture #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
shoota
commented
Jul 10, 2018
| "build": "tsc", | ||
| "clean": "rimraf coverage lib docs", | ||
| "prepublish": "npm run build", | ||
| "test": "karma start --single-run" |
Contributor
Author
There was a problem hiding this comment.
karma test will run from root packages. Test files are defined packages/*/test/**/*.ts.
https://github.com/userdive/agent.js/blob/master/karma.conf.ts#L103
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
=======================================
Coverage 91.38% 91.38%
=======================================
Files 23 23
Lines 592 592
Branches 103 103
=======================================
Hits 541 541
Misses 27 27
Partials 24 24 |
heavenshell
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Closes #612
Check this pr.
How to check
Check list