Update Locale File Keys

[amosfolz]

Generated missing locale keys for all languages using PR #992 locale:fix-keys command.

The empty key values were populated using en_US and can be identified via locales:missing-values command.

(also wanted to check these files will pass style-ci check)

I also had to go through and modify some files manually to fix keys that were present in other locales but not in en_US. Some of these were due to keys not being in correct sub keys or improper formatting.

[codecov]

Codecov Report

Merging #1006 into develop will not change coverage.
The diff coverage is 20%.

@@            Coverage Diff             @@
##             develop    #1006   +/-   ##
==========================================
  Coverage      66.99%   66.99%           
  Complexity      1923     1923           
==========================================
  Files            161      161           
  Lines           6703     6703           
==========================================
  Hits            4491     4491           
  Misses          2212     2212

Impacted Files	Coverage Δ	Complexity Δ
app/sprinkles/core/src/Util/CheckEnvironment.php	2.91% <0%> (ø)	41 <0> (ø)	⬇️
...sprinkles/admin/src/Controller/GroupController.php	100% <100%> (ø)	55 <0> (ø)	⬇️
.../sprinkles/admin/src/Controller/RoleController.php	100% <100%> (ø)	71 <0> (ø)	⬇️
.../sprinkles/admin/src/Controller/UserController.php	99.59% <100%> (ø)	112 <0> (ø)	⬇️
app/sprinkles/account/src/Database/Models/User.php	75.65% <100%> (ø)	35 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a555a3...3237781. Read the comment docs.

[lcharette]

Would it be easier for translators if we comment all untranslated keys? I know it won't work with the upcoming Bakery commands, but it would make it easier to spot what needs translation and actually use the English fallback instead of having outdated English strings in whatever locale.

[amosfolz]

Would it be easier for translators if we comment all untranslated keys? I know it won't work with the upcoming Bakery commands, but it would make it easier to spot what needs translation and actually use the English fallback instead of having outdated English strings in whatever locale.

I can do that if you think it's best.

I do have a table with the untranslated keys that I was going to put into a new issue for translators to reference.

[amosfolz]

I commented out the keys in recent commits.

[lcharette]

PHP Parse error:  syntax error, unexpected ';', expecting ']' in /home/travis/build/userfrosting/UserFrosting/app/sprinkles/core/config/default.php on line 408

https://travis-ci.org/userfrosting/UserFrosting/jobs/571120012#L881

[amosfolz]

PHP Parse error:  syntax error, unexpected ';', expecting ']' in /home/travis/build/userfrosting/UserFrosting/app/sprinkles/core/config/default.php on line 408

https://travis-ci.org/userfrosting/UserFrosting/jobs/571120012#L881

I'm not even sure where this change came from?

[lcharette]

Something barfed 🤔
https://travis-ci.org/userfrosting/UserFrosting/jobs/571375743#L881

[amosfolz]

I don't even understand what happened here...
Missing closing bracket https://github.com/amosfolz/UserFrosting/blame/hotfix-update-locale-files/app/sprinkles/core/config/default.php#L105-L111 ?

[amosfolz]

Also, php-cs-fixer is trying to do weird things like change comments now:

[lcharette]

I think it should be safe to merge now? PHP-CS-Fixer didn't brought up any issue on my side?

[amosfolz]

I think it should be safe to merge now? PHP-CS-Fixer didn't brought up any issue on my side?

I think it is good to go.