update page404() to respond with 404 code and other#567
Merged
Netrilix merged 6 commits intouserfrosting:hotfix-0.3.1.16from Jul 9, 2016
Merged
update page404() to respond with 404 code and other#567Netrilix merged 6 commits intouserfrosting:hotfix-0.3.1.16from
Netrilix merged 6 commits intouserfrosting:hotfix-0.3.1.16from
Conversation
merge current
This renders the 404 page via slim's halt() method. It also fixes the issue of unexpected 200 response codes with erroneous (mostly typo ridden) ajax requests.
Seems like the `pageDatabaseError()` is a good place to do this as well.
both work, but this makes more sense.
Member
|
Has this been tested with the installer? You'll notice the comment:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, use
503for pageDatabaseError(). See individual commits for more detail