Skip to content

Number of small UI fixes#573

Merged
Netrilix merged 10 commits intouserfrosting:hotfix-developmentfrom
frostbitten:master
Jul 15, 2016
Merged

Number of small UI fixes#573
Netrilix merged 10 commits intouserfrosting:hotfix-developmentfrom
frostbitten:master

Conversation

@frostbitten
Copy link
Copy Markdown
Contributor

@frostbitten frostbitten commented Jul 12, 2016 •
edited
Loading

  1. Additional boostrap css selector .container-narrow now has a maximum width set, rather than a static width.
  2. Installation screens are more responsive by utilizing bootstrap's ability to define column sizes for different viewports. Replacement of col-sm-12 with col-xs-12 to guarantee widths on an "extra small" screen.
  3. Site settings page is similarly updated to be more responsive. Text in some labels was overset, lying on top of other text or controls. This edit utilizes a slightly larger column size for the labels.
  4. Send a 503 status code along with notice that config-userfrosting.php can't be found.

Installation Ready

Installation Error

Site Settings

Preview of the modified settings page. Notice the similar style of the .well class to <pre><code>

image

config-userfrosting not found

503 status.
image

@frostbitten
Merge pull request #10 from userfrosting/master
70e3a42 
merge current
@frostbitten
update page404() to respond with 404 response code
e08bcc8 
This renders the 404 page via slim's halt() method. It also fixes the issue of unexpected 200 response codes with erroneous (mostly typo ridden) ajax requests.
@frostbitten
Do same with pageDatabaseError() and remove hook
6d8328d 
Seems like the `pageDatabaseError()` is a good place to do this as well.
@frostbitten
Use 503 (service unavailable) for pageDatabaseError()
6277361
@frostbitten
use pageDatabaseError() if UserSession hits a PDOException
655a362
@frostbitten
use BaseController
196425c 
both work, but this makes more sense.
@frostbitten
Merge remote-tracking branch 'refs/remotes/main/master'
4ef420a 
Conflicts:
	userfrosting/controllers/BaseController.php
@frostbitten
UI fixes
0c621d3 
A few cases where col-xs-12 could be used. Some changes to settings page where certain text would not fit in label. Better to have extra space than overlapping text. Some `div.well` elements converted to `<pre><code>` to prevent text falling out of panels
@frostbitten
More ui fixes
e027d75 
This commit adds a few bootstrap4 css utilities the most important being `.img-fluid`.
@Netrilix
Copy link
Copy Markdown
Contributor

Netrilix commented Jul 14, 2016

Testing this now. Any chance you can fix the whitespace on install-ready.twig and install-errors.twig? Assuming @alexweissman is okay with it and my tests go well, I'm going to merge it in and push this hotfix live tonight because of the installation and log-reader problems.

@frostbitten
Copy link
Copy Markdown
Contributor Author

frostbitten commented Jul 14, 2016

Yeah it's an issue with my text editor and tabs vs. spaces. All set.

@frostbitten
replace tabs with 4 spaces
e7966b4 
and trim trailing
@Netrilix
Copy link
Copy Markdown
Contributor

Netrilix commented Jul 14, 2016

You available to chat on UF Chat for a couple minutes? Had some ideas about the installation problem.

@Netrilix Netrilix merged commit 3e8bb5b into userfrosting:hotfix-development Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frostbitten @Netrilix