Skip to content

Added cache control to fix bug with internet explorer not updating UF table data #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aminazirani wants to merge 1 commit into from
Closed

Added cache control to fix bug with internet explorer not updating UF table data #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/sprinkles/admin/src/Controller/ActivityController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ public function getList($request, $response, $args)

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
return $sprunje->toResponse($response);
//set cache headers in order to stop specially IE to cache the result
return $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');
}

/**
Expand Down
6 changes: 4 additions & 2 deletions app/sprinkles/admin/src/Controller/GroupController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,8 @@ public function getList($request, $response, $args)

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
return $sprunje->toResponse($response);
//set cache headers in order to stop specially IE to cache the result
return $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');
}

public function getModalConfirmDelete($request, $response, $args)
Expand Down Expand Up @@ -474,7 +475,8 @@ public function getUsers($request, $response, $args)

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
return $sprunje->toResponse($response);
//set cache headers in order to stop specially IE to cache the result
return $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');
}

/**
Expand Down
8 changes: 5 additions & 3 deletions app/sprinkles/admin/src/Controller/PermissionController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ public function getList($request, $response, $args)

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
return $sprunje->toResponse($response);
//set cache headers in order to stop specially IE to cache the result
return $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');
}

/**
Expand Down Expand Up @@ -133,8 +134,9 @@ public function getUsers($request, $response, $args)
$params['permission_id'] = $args['id'];

$sprunje = $classMapper->createInstance('permission_user_sprunje', $classMapper, $params);

$response = $sprunje->toResponse($response);

//set cache headers in order to stop specially IE to cache the result
$response = $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
Expand Down
9 changes: 6 additions & 3 deletions app/sprinkles/admin/src/Controller/RoleController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,8 @@ public function getList($request, $response, $args)

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
return $sprunje->toResponse($response);
//set cache headers in order to stop specially IE to cache the result
return $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');
}

public function getModalConfirmDelete($request, $response, $args)
Expand Down Expand Up @@ -526,7 +527,8 @@ public function getPermissions($request, $response, $args)

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
return $sprunje->toResponse($response);
//set cache headers in order to stop specially IE to cache the result
return $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');
}

/**
Expand Down Expand Up @@ -571,7 +573,8 @@ public function getUsers($request, $response, $args)

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
return $sprunje->toResponse($response);
//set cache headers in order to stop specially IE to cache the result
return $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');
}

/**
Expand Down
14 changes: 9 additions & 5 deletions app/sprinkles/admin/src/Controller/UserController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@ public function getActivities($request, $response, $args)

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
return $sprunje->toResponse($response);
//set cache headers in order to stop specially IE to cache the result
return $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');
}

/**
Expand Down Expand Up @@ -420,7 +421,8 @@ public function getList($request, $response, $args)

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
return $sprunje->toResponse($response);
//set cache headers in order to stop specially IE to cache the result
return $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');
}

/**
Expand Down Expand Up @@ -768,8 +770,9 @@ public function getPermissions($request, $response, $args)

$params['user_id'] = $user->id;
$sprunje = $classMapper->createInstance('user_permission_sprunje', $classMapper, $params);

$response = $sprunje->toResponse($response);

//set cache headers in order to stop specially IE to cache the result
$response = $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
Expand Down Expand Up @@ -818,7 +821,8 @@ public function getRoles($request, $response, $args)

// Be careful how you consume this data - it has not been escaped and contains untrusted user-supplied content.
// For example, if you plan to insert it into an HTML DOM, you must escape it on the client side (or use client-side templating).
return $sprunje->toResponse($response);
//set cache headers in order to stop specially IE to cache the result
return $sprunje->toResponse($response)->withHeader('Cache-Control', 'no-cache')->withHeader('Expires', '-1');
}

/**
Expand Down