ClassMapper and Docker improvements#936
Merged
Silic0nS0ldier merged 15 commits intodevelopfrom Feb 16, 2019
Merged
Conversation
…into develop-jordan
- Noted area needing improvement in asset build script
- Minor clean up of unneeded docker configurations
Silic0nS0ldier
changed the title
Member
Author
|
Well, it seems that while PHP 5.6 supports the syntax, it doesn't support compound syntax. Unsupported changes will be split off to another branch in the meantime for 4.3. |
Silic0nS0ldier
force-pushed
the
develop-jordan
branch
from
55bb88d to
cdc2d71
Compare
Silic0nS0ldier
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #936 +/- ##
=============================================
+ Coverage 36.85% 36.87% +0.01%
Complexity 2120 2120
=============================================
Files 158 158
Lines 7212 7211 -1
=============================================
+ Hits 2658 2659 +1
+ Misses 4554 4552 -2
Continue to review full report at Codecov.
|
- Use Alpine for PHP - Removed commands from composer and node services in favour of on-demand command execution - Updated docker README
Silic0nS0ldier
changed the title
- Bower updated to address vulnerability
lcharette
reviewed
Feb 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original goal here was to improve readability of code when the class mapper is used. Unfortunately PHP 5.6's ability to handle compound statements is atrocious, so the scope of the changes has been severely limited and the incompatible changes have been pushed off to another 4.3 specific branch.
There area few other tidbits in here as well (docker, README, etc) that should be non-functional changes for the most part.