fix: prevent premature webhook auto-disable and allow re-enable#364
fix: prevent premature webhook auto-disable and allow re-enable#364
Conversation
Use persisted failure counters when deciding auto-disable status and restore dashboard re-enable flow so webhooks are not deactivated unexpectedly after reset.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
WalkthroughThis PR updates webhook behavior and docs: adds an email.rendering_failure event in docs and replaces Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Only increment consecutive failure counters after a call exhausts retries, while keeping the 30-call auto-disable threshold and stale-state protection.
Mock limit service in webhook unit tests so Vitest does not resolve team-service and mailer paths requiring usesend-js during CI.
Summary
AUTO_DISABLEDwebhooks to be activated again from both webhook list and webhook detail actions in the dashboardTesting
pnpm --filter web exec vitest run -c vitest.unit.config.ts \"src/server/service/webhook-service.unit.test.ts\"Summary by cubic
Fixes webhook failure handling to count failures per failed call and prevent early auto-disable. Restores the ability to re-enable AUTO_DISABLED webhooks in the dashboard.
Written for commit 55c9d56. Summary will update on new commits.
Summary by CodeRabbit
New Features
Improvements
Documentation
Tests