chore: remove codex models from supported models#342
Merged
Conversation
Contributor
Greptile SummaryThis PR removes 4 codex model entries ( Major issues:
The removal is incomplete and creates inconsistency between code and documentation. Confidence Score: 2/5
Important Files Changed
Last reviewed commit: 5a5a5fb |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
50
to
52
| | GPT-5.2 | `strix/gpt-5.2` | | ||
| | GPT-5.1 | `strix/gpt-5.1` | | ||
| | GPT-5 | `strix/gpt-5` | |
Contributor
There was a problem hiding this comment.
Codex models removed from this table but still defined in strix/llm/utils.py lines 40-43 in STRIX_MODEL_MAP. Users can still access these models via the code even though they're not documented.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/llm-providers/models.mdx
Line: 50-52
Comment:
Codex models removed from this table but still defined in `strix/llm/utils.py` lines 40-43 in `STRIX_MODEL_MAP`. Users can still access these models via the code even though they're not documented.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
50
to
52
| | GPT-5.2 | `strix/gpt-5.2` | | ||
| | GPT-5.1 | `strix/gpt-5.1` | | ||
| | GPT-5 | `strix/gpt-5` | |
Contributor
There was a problem hiding this comment.
docs/llm-providers/overview.mdx:52 still mentions "GPT-5 and Codex models" - should update to just "GPT-5 models"
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/llm-providers/models.mdx
Line: 50-52
Comment:
`docs/llm-providers/overview.mdx:52` still mentions "GPT-5 and Codex models" - should update to just "GPT-5 models"
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
50
to
52
| | GPT-5.2 | `strix/gpt-5.2` | | ||
| | GPT-5.1 | `strix/gpt-5.1` | | ||
| | GPT-5 | `strix/gpt-5` | |
Contributor
There was a problem hiding this comment.
PR description mentions "removing from docs and config.yaml" but no config.yaml file was modified in this commit
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/llm-providers/models.mdx
Line: 50-52
Comment:
PR description mentions "removing from docs and config.yaml" but no `config.yaml` file was modified in this commit
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing from docs and config.yaml for litellm deployment