Conversation
Removed specific tool files from Dockerfile and added a directory copy instead.
Contributor
Greptile SummaryThis PR simplifies the Key observations:
Confidence Score: 4/5
Important Files Changed
Prompt To Fix All With AIThis is a comment left during a code review.
Path: containers/Dockerfile
Line: 176
Comment:
**Previously omitted tool directories now included**
The old Dockerfile explicitly listed only 6 subdirectories (`browser`, `file_edit`, `notes`, `python`, `terminal`, `proxy`). The new `COPY strix/tools/ /app/strix/tools/` will also include the following directories that were previously **not** copied into the image:
- `strix/tools/agents_graph/`
- `strix/tools/finish/`
- `strix/tools/load_skill/`
- `strix/tools/reporting/`
- `strix/tools/thinking/`
- `strix/tools/todo/`
- `strix/tools/web_search/`
If these were intentionally excluded before (e.g., work-in-progress, not yet wired into the runtime), this change silently activates them in the image. Worth confirming the intent — if this is the desired fix it's great, but a brief note in the PR description would add clarity.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Simplify tool file copying in Dockerfile" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed specific tool files from Dockerfile and added a directory copy instead.