Skip to content

feat: implement s3 dump extension#218

Merged
jaronoff97 merged 4 commits into
masterfrom
feat/policy-zig-0.5-s3-dump
Jul 10, 2026
Merged

feat: implement s3 dump extension#218
jaronoff97 merged 4 commits into
masterfrom
feat/policy-zig-0.5-s3-dump

Conversation

@jaronoff97

Copy link
Copy Markdown
Contributor

No description provided.

@macroscopeapp

macroscopeapp Bot commented Jul 10, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

This PR introduces a new S3 dump extension feature with significant new runtime behavior including background flush tasks, extension sink wiring through log processing, and new configuration types. Additionally, an unresolved comment identifies that temporary IAM credentials (Lambda/ECS/EKS) won't work due to missing AWS_SESSION_TOKEN handling. New features of this scope warrant human review.

You can customize Macroscope's approvability policy. Learn more.

Comment thread src/signals/datadog/logs.zig Outdated
Comment thread src/signals/otlp/metrics.zig
Comment thread src/config/types.zig
smithclay
smithclay previously approved these changes Jul 10, 2026
Comment thread src/signals/datadog/logs.zig
Comment thread src/runtime/extensions.zig
@jaronoff97 jaronoff97 merged commit 5fa6b03 into master Jul 10, 2026
5 checks passed
@jaronoff97 jaronoff97 deleted the feat/policy-zig-0.5-s3-dump branch July 10, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants