Open
Conversation
jurgenvinju
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2738 +/- ##
=======================================
- Coverage 46% 46% -1%
+ Complexity 6737 6732 -5
=======================================
Files 794 794
Lines 65923 65936 +13
Branches 9888 9888
=======================================
+ Hits 30858 30861 +3
- Misses 32684 32687 +3
- Partials 2381 2388 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
6 tasks
toinehartman
reviewed
Apr 8, 2026
| assert isSorted(edits, less=bool (TextEdit e1, TextEdit e2) { | ||
| return e1.range.offset < e2.range.offset; | ||
| }); | ||
| // assert isSorted(edits, less=bool (TextEdit e1, TextEdit e2) { |
Member
There was a problem hiding this comment.
Commented code: can we remove this?
| @@ -27,6 +27,8 @@ module analysis::diff::edits::HiFiLayoutDiff | |||
| extend analysis::diff::edits::HiFiTreeDiff; | |||
| import ParseTree; // this should not be necessary because imported by HiFiTreeDiff | |||
| import String; // this should not be be necessary because imported by HiFiTreeDiff | |||
Member
There was a problem hiding this comment.
Does this indicate a type-checker bug? Has this already been solved in a RC of the extension?
| L("\<:"), | ||
| toBox(bound)); | ||
|
|
||
| // TODO: put these functions on top after the function cache issue has been resolved: |
|
|
||
| private Symbol strip(label(_, Symbol s)) = strip(s); | ||
| private Symbol strip(conditional(Symbol s, _)) = strip(s); | ||
| default Symbol strip(Symbol s) = s; No newline at end of file |
Member
There was a problem hiding this comment.
Shouldn't this be private as well?
| } | ||
|
|
||
| @synopsis{Yields the characters of a parse tree as the original input sentence in a <code>...</code> block, but with spans for highlighted segments in HTML} | ||
| public str toHTML(Tree t) { |
Member
There was a problem hiding this comment.
This removes a public stdlib definition. Is this supposed to be replaced by the renamed definition (ToHTML => toHTML) higher up in this file?
| See ((IO-iprint)) for a version that displays the result on the console | ||
| and ((IO-iprintExp)) for a version that returns its argument as result | ||
| and ((IO-iprintln)) for a version that adds a newline. | ||
|
|
Member
There was a problem hiding this comment.
Is this empty line intentional?
| } | ||
|
|
||
| @synopsis{Convenience function for reporting progress on a for loop over a set, with a list of results.} | ||
| list[&U] loopJob(set[&T] work, &U(&T) consumer, str label = "", str (&T) stepLabel = str(&T w) { return "<w>"; }) { |
Member
There was a problem hiding this comment.
Why a list of results instead of a set?
| (isEmpty(xs))? [] : ([head(xs)] | it + [sep,x] | x <- tail(xs)); | ||
|
|
||
| list[&T] intersperse(&T sep, list[&T] xs) = | ||
| [x, sep | &T x <- xs][..-1]; |
| * Type inference has a guaranteed least or greatest solution, always. This means that constraints are always solvable in an unambiguous manner. | ||
| * A _principal type_ can always be computed, which is a most precise and unique solution of a type inference problem. Without the lattice, solution candidates could become incomparable and thus ambiguous. Without | ||
| this principal type property, type inference is predictable for programmers. | ||
| this principal type property, type inference is unpredictable for programmers. |
Member
There was a problem hiding this comment.
That's quite the difference 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a redo of #2346 which was mangled due to a wrong use of git-filter-repo