Filter serial port picker to TRMNL ESP32-C3 devices only#7
Closed
hossain-khan wants to merge 1 commit intousetrmnl:masterfrom
Closed
Filter serial port picker to TRMNL ESP32-C3 devices only#7hossain-khan wants to merge 1 commit intousetrmnl:masterfrom
hossain-khan wants to merge 1 commit intousetrmnl:masterfrom
Conversation
The @zjwhitehead/esp-web-tools fork calls navigator.serial.requestPort() without passing filters, so the browser shows all serial ports (Bluetooth, debug consoles, etc). This patch injects USB VID/PID filters (Espressif 0x303A / ESP32-C3 0x1001) to restrict the picker to TRMNL devices only. Also adds the serial-port-filters attribute on the esp-web-install-button element for forward-compatibility if the library adds native support. Fixes #6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves user-experience when selecting device from USB-C by filtering out only TRMNL devices.
The @zjwhitehead/esp-web-tools fork calls
navigator.serial.requestPort()without passing filters, so the browser shows all serial ports (Bluetooth, debug consoles, etc). This patch injects USB VID/PID filters (Espressif 0x303A / ESP32-C3 0x1001) to restrict the picker to TRMNL devices only.Also adds the serial-port-filters attribute on the esp-web-install-button element for forward-compatibility if the library adds native support.
Fixes #6
Demo