This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Apply winpi.patch#558
Merged
emthompson-usgs merged 3 commits intousgs:masterfrom Dec 18, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
- Coverage 81.19% 81.18% -0.02%
==========================================
Files 108 108
Lines 10590 10590
==========================================
- Hits 8599 8597 -2
- Misses 1991 1993 +2
Continue to review full report at Codecov.
|
|
It would be nice to run the tests on Windows. Here is an example of a conda GitHub Actions in case you want to try it. |
Member
Author
|
Will do. Working on adding Windows builds to our azure pipeline in #559. |
Member
Author
|
I suspect this will uncover some python code that is not compatible with Windows that I'll need to address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch by @ocefpaf to fix Windows build problems.