Allow users to set frequency time #159
Conversation
Preference list changed to edit text field. Edit text field is generally idiot proof.
|
From a first gland at the code, I'm not sure how we're calculating / indicating time as seconds as opposed to minutes. Say the user want the frequency time to be 30 seconds. Should it be float? say 0.1 or 0.30 to indicate seconds and then 1 or 30 indicates minutes. Thoughts? I'm traveling so will be slow at reviewing but I give this a proper review once I settle in next week. |
|
The issue mentioned only changing the form of input, not the type of input itself. I would keep the integer, but change its meaning from minutes to seconds. Then modify the content of the dialog something like "MM:SS". Maybe two edittext fields divided by colon, or one that displays a toast informing that time should like like mentioned above. Waiting for your response. |
|
@123725 We can use something like a time picker? See this http://stackoverflow.com/questions/5533078/timepicker-in-preferencescreen |
|
@123725 thoughts on my previous comment |
Preference list changed to edit text with validation. ( Integer.valueOf(str) > 0 && str.length() > 0 )