#120 - Tasks for sending sms should appear in pending tray, before going to sent tray.

[tstalka]

No description provided.

[eyedol]

Not important but the else isn't necessary

[KamilKalfas]

Since @tstalka will be no more contributing i will take this task. @eyedol i think you should close this PR when i will create the new one with updates

[eyedol]

Did @tstalka move on? Can you push the updates to this one? otherwise I'll close it when you open the new PR.

[KamilKalfas]

Yea, he changed team. Sadly no cause this is on his fork.

[eyedol]

oh...

[KamilKalfas]

@eyedol the reason why those elses are needed is that there is no PRIMARY KEY defined in tables. In this case when there is no match for new sent message UUID in database, updated will return 0, and then insert will be executed. So i think you can merge it without need of creating new PR.

[eyedol]

@KamilKalfas oh from a readability point of view, it makes sense without the else you can reach the same logic without it.

I haven't tested it yet. I'll merge it when I play with it.

[Nhorning]

I highly appreciate this being included in the new version, but I haven't got a chance to test it, since SMS are not sending at all. once that issue is fixed I'll be able to give constructive feedback.