Issue #164: Migrated from ActionBarSherlock to ActionBarCompact.#175
Merged
eyedol merged 1 commit intoushahidi:developfrom Jun 4, 2014
KamilKalfas:issue-164
Merged
Issue #164: Migrated from ActionBarSherlock to ActionBarCompact.#175eyedol merged 1 commit intoushahidi:developfrom KamilKalfas:issue-164
eyedol merged 1 commit intoushahidi:developfrom
KamilKalfas:issue-164
Conversation
Contributor
Author
|
@eyedol please look into this :) |
Collaborator
|
@KamilKalfas I made some minor comments on the PR. They're on your fork. |
Contributor
Author
|
Thanks @eyedol ! Fixed and find out that i left one TODO but is also fixed. New drawables are needed to keep same look of SMSSync. Sherlock style was looking great, whole black etc. With new styles from support lib, it was gray instead of black, some parts of text weren't visible. Also on action bar you could notice background of text SMSSync and icon. So I've tweaked up it. |
Collaborator
|
Great! |
eyedol
added a commit
that referenced
this pull request
Jun 4, 2014
Issue #164: Migrated from ActionBarSherlock to ActionBarCompact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.