Issue 182: added sms-portals and flavors #190
Issue 182: added sms-portals and flavors #190kkanigowski wants to merge 3 commits intoushahidi:developfrom
Conversation
|
@eyedol please check this if that is what you have expected |
|
I think we still need docs here too? To explain how sms portals works a bit more. We should include them here or open an issue for it. |
|
@mandric yes I think you have to create new issue for docs. |
|
@eyedol please check this PR. |
There was a problem hiding this comment.
Could you rename this to package com.smssync.portal.one? Aligns well with the package names for the other flavours.
|
@kkanigowski why do you open a new |
|
@eyedol it was in the beginning, now I only push. Hard coding is remain from earlier commits which have written by other man. I will check all his changes and update strings. Thank you for your response. |
|
Pull in changes from mainstream develop |
…d messages throuh installed Sms Portal packages. Conflicts: smssync/src/main/java/org/addhen/smssync/Prefs.java smssync/src/main/java/org/addhen/smssync/Settings.java smssync/src/main/java/org/addhen/smssync/messages/ProcessSms.java
made summary more concise and variable naming more consistent. doc updates coming soon. Conflicts: smssync/src/main/java/org/addhen/smssync/Settings.java smssync/src/main/res/values/strings.xml smssync/src/main/res/xml/preferences.xml
|
@kkanigowski Could you fix the minor comment. I'll merge after. Overall it looks good to me. Left with documentation for the website. I'll create an issue for it. Guys, thanks for the hard work. |
5 participants
No description provided.