Simplify implementation of State.isRunning()#407
Merged
eyedol merged 1 commit intoushahidi:masterfrom Apr 22, 2016
Merged
Conversation
|
|
||
| public boolean isRunning() { | ||
| return EnumSet.of(SyncState.SYNC).contains(state); | ||
| return state == SyncState.SYNC; |
Collaborator
There was a problem hiding this comment.
Though this works I prefer the SyncState.Sync.equals(state); as it reads much better to me. You using == for null safety?
Contributor
Author
There was a problem hiding this comment.
Certainly is null-safe, but I was only using it because using == on enums is safe, and quicker to type ;¬) Can change to .equals() if you prefer.
Collaborator
There was a problem hiding this comment.
I'll take safety over readability then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No obvious reason to create a new
EnumSetwith one element each time this method is called.