Improvements to documentation#72
Merged
eyedol merged 11 commits intoushahidi:developfrom Jan 11, 2013
olliebennett:master
Merged
Improvements to documentation#72eyedol merged 11 commits intoushahidi:developfrom olliebennett:master
eyedol merged 11 commits intoushahidi:developfrom
olliebennett:master
Conversation
@eyedol went ahead and created a proper branch for this patch, hopefully more useful to you. tested in emulator on Android 2.3.
patch for wifi lock issue observed in #56.
added isHeld() checks when acquiring wake and wifi locks in SmsSyncServices
to remove duplicate information that can be found elsewhere.
... now conforms better to design guidelines at http://developer.android.com/design/get-started/principles.html Note: These changes will need to be migrated to Transifex to be retained.
Clarified some points, fixed typos etc.
Contributor
Author
|
Any plan to accept this? Is there any work I can do to ease the process? |
Collaborator
|
@olliebennett I'll review this when I get back from vacation. Thanks for the hard work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used the master branch, as it was more up-to-date than the develop branch.
You may not want to pull the following commits: